From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] btrfs: rename the extra_gfp parameter of btrfs_alloc_page_array()
Date: Mon, 1 Jul 2024 16:03:47 +0200 [thread overview]
Message-ID: <20240701140347.GD21023@twin.jikos.cz> (raw)
In-Reply-To: <CAL3q7H6Nd7f3XEoPGgyovryvF0eMat+25++nwd3W=bSBDSActA@mail.gmail.com>
On Fri, Jun 28, 2024 at 10:33:19AM +0100, Filipe Manana wrote:
> On Fri, Jun 28, 2024 at 5:22 AM Qu Wenruo <wqu@suse.com> wrote:
> >
> > There is only one caller utilizing the @extra_gfp parameter,
> > alloc_eb_folio_array().
> > And in that case the extra_gfp is only assigned to __GFP_NOFAIL.
> >
> > This patch would rename the @extra_gfp parameter to @nofail to indicate
> > that.
>
> "would rename" -> renames
Ideally also leave out the whole 'This patch ...', I've been fixing that
when I notice it but I've just found more in now immutable patches so
it's obviously not perfect.
prev parent reply other threads:[~2024-07-01 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 4:21 [PATCH v2 0/2] btrfs: cleanup on the extra_gfp parameters Qu Wenruo
2024-06-28 4:21 ` [PATCH v2 1/2] btrfs: remove the extra_gfp parameter from btrfs_alloc_folio_array() Qu Wenruo
2024-06-28 4:21 ` [PATCH v2 2/2] btrfs: rename the extra_gfp parameter of btrfs_alloc_page_array() Qu Wenruo
2024-06-28 9:33 ` Filipe Manana
2024-07-01 14:03 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701140347.GD21023@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox