Re: [PATCH 1/4] module: Add module_subinit{_noexit} and module_subeixt helper macros

Christoph Hellwig
2024-07-29T18:57:44Z

On Sun, Jul 28, 2024 at 10:44:12PM -0400, Theodore Ts'o wrote:
> >
> > Personally, I prefer the implementation of method two.
>
> But there's also method zero --- keep things the way they are, and
> don't try to add a new astraction.
>
> Advantage:
>
> -- Code has worked for decades, so it is very well tested
> -- Very easy to understand and maintain
>
> Disadvantage
>
> --- A few extra lines of C code.
>
> which we need to weigh against the other choices.

I think option zero is the right option for you and David and anyone
scared of link order issues.

But I know for XFS or the nvme code having multiple initcalls per
module would be extremely helpfu. I don't really want to drag Youling
into implementing something he is not behind, but I plan to try that
out myself once I find a little time.