Re: [PATCH] btrfs: reduce size and overhead of extent_map_block_end()

[Josef Bacik <josef@toxicpanda.com>]

On Tue, Jul 23, 2024 at 04:16:03PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> At extent_map_block_end() we are calling the inline functions
> extent_map_block_start() and extent_map_block_len() multiple times, which
> results in expanding their code multiple times, increasing the compiled
> code size and repeating the computations those functions do.
> 
> Improve this by caching their results in local variables.
> 
> The size of the module before this change:
> 
>    $ size fs/btrfs/btrfs.ko
>       text	   data	    bss	    dec	    hex	filename
>    1755770	 163800	  16920	1936490	 1d8c6a	fs/btrfs/btrfs.ko
> 
> And after this change:
> 
>    $ size fs/btrfs/btrfs.ko
>       text	   data	    bss	    dec	    hex	filename
>    1755656	 163800	  16920	1936376	 1d8bf8	fs/btrfs/btrfs.ko
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef