Re: [PATCH 00/46] btrfs: convert most of the data path to use folios

[Josef Bacik <josef@toxicpanda.com>]

On Fri, Jul 26, 2024 at 08:55:54PM -0400, Neal Gompa wrote:
> On Fri, Jul 26, 2024 at 6:58 PM Qu Wenruo <quwenruo.btrfs@gmx.com> wrote:
> >
> >
> >
> > 在 2024/7/27 05:05, Josef Bacik 写道:
> > > Hello,
> > >
> > > Willy indicated that he wants to get rid of page->index in the next merge
> > > window, so I went to look at what that would entail for btrfs, and I got a
> > > little carried away.
> > >
> > > This patch series does in fact accomplish that, but it takes almost the entirety
> > > of the data write path and makes it work with only folios.  I was going to
> > > convert everything, but there's some weird gaps that need to be handled in their
> > > own chunk.
> > >
> > > 1. Scrub.  We're still passing around page pointers.  Not a huge deal, it was
> > >     just another 10ish patches just for that work, so I decided against it.
> > >
> > > 2. Buffered writes.  Again, I did most of this work and it wasn't bad, but then
> > >     I realized that the free space cache uses some of this code, and I really
> > >     don't want to convert that code, I want to delete it, so I'll do that first.
> >
> > Totally agree, v1 is better to be deprecated.
> >
> 
> Didn't we already deprecate it? We should just announce the removal schedule.
> 
> > >
> > > 3. Metadata.  Qu has been doing this consistently and I didn't want to get in
> > >     the way of his work so I just left most of that.
> >
> > I guess there are still metadata codes switching between page and folios.
> >
> > I'm totally fine if you feel like to convert them to use folios.
> > The only focus for me is to enable larger folios.
> > So the conversion part is totally fine.
> >
> > >
> > > This has run through the CI and didn't cause any issues.  I've made everything
> > > as easy to review as possible and as small as possible.  My eyes started to
> > > glaze over a little bit with the changelogs, so let me know if there's anything
> > > you want changed.  Thanks,
> >
> > Just give us some time to review the whole series though, the pure
> > amount of patches is already making my eyes glazing.
> >
> 
> I'm impressed, but my eyes are glazing over reading it patch by patch
> through emails, do you happen to have a branch on GitHub/GitLab/etc.
> that I could look at it through instead?

Yup it's here

https://github.com/josefbacik/linux/tree/btrfs-convert-readahead

Thanks,

Josef