From: David Sterba <dsterba@suse.cz>
To: Mark Harmstone <maharmstone@fb.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: simplify mkfs_main cleanup
Date: Tue, 30 Jul 2024 01:47:10 +0200 [thread overview]
Message-ID: <20240729234710.GX17473@twin.jikos.cz> (raw)
In-Reply-To: <20240722143235.1022223-1-maharmstone@fb.com>
On Mon, Jul 22, 2024 at 03:32:24PM +0100, Mark Harmstone wrote:
> mkfs_main is a main-like function, meaning that return and exit are
> equivalent. Deduplicate our cleanup code by moving the error label.
>
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
Added to devel, thanks. It adds more code but at least removes the exit
block duplication. The 'success' label can be further moved before the
'return !!ret' so we don't have two exit points.
prev parent reply other threads:[~2024-07-29 23:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 14:32 [PATCH v2] btrfs-progs: simplify mkfs_main cleanup Mark Harmstone
2024-07-29 23:47 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729234710.GX17473@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=maharmstone@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox