From: David Sterba <dsterba@suse.cz>
To: Mark Harmstone <maharmstone@meta.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: add io_uring interface for encoded reads
Date: Mon, 12 Aug 2024 13:23:42 +0200 [thread overview]
Message-ID: <20240812112342.GE25962@suse.cz> (raw)
In-Reply-To: <879d0861-9a67-4e02-b6ec-60f2c6c6cb40@meta.com>
On Mon, Aug 12, 2024 at 09:20:19AM +0000, Mark Harmstone wrote:
> On 9/8/24 19:34, David Sterba wrote:
> > Where is the CAP_SYS_ADMIN check done? It's not in this patch so I
> > assume it's somewhere in io_uring but I don't see it. Thanks.
>
> It still gets done in btrfs_ioctl_encoded_read, which gets called by
> io_uring in a task with the process context.
Oh of course. The io_uring wrapper is simple so the check does not have
to be lifted from the function.
next prev parent reply other threads:[~2024-08-12 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 17:35 [PATCH] btrfs: add io_uring interface for encoded reads Mark Harmstone
2024-08-09 18:34 ` David Sterba
2024-08-12 9:20 ` Mark Harmstone
2024-08-12 11:23 ` David Sterba [this message]
2024-08-12 11:26 ` Christoph Hellwig
2024-08-12 14:46 ` Mark Harmstone
2024-08-12 15:03 ` Pavel Begunkov
2024-08-12 16:10 ` Pavel Begunkov
2024-08-12 16:58 ` David Sterba
2024-08-12 19:17 ` Pavel Begunkov
2024-08-13 0:49 ` David Sterba
2024-08-13 1:06 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812112342.GE25962@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=maharmstone@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox