From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: Mark Harmstone <maharmstone@fb.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v5] btrfs-progs: add --subvol option to mkfs.btrfs
Date: Wed, 14 Aug 2024 23:47:31 +0200 [thread overview]
Message-ID: <20240814214731.GA25962@suse.cz> (raw)
In-Reply-To: <83f9b6b1-9027-41e5-b0ee-c667dd181fa4@oracle.com>
On Tue, Aug 13, 2024 at 08:52:04AM +0800, Anand Jain wrote:
>
> Nice feature.
>
> >> + OPTLINE("-u|--subvol SUBDIR", "create SUBDIR as subvolume rather than normal directory"),
> >
> > Please mention that it can be specified multiple times.
>
> Nitpick..
>
> Should '--subvol' be '--subvolume' for consistency? use the full names.
For convenience both can be accepted, there are aliases for options. The
subcommand names are recognized if abbreviated and still unique, I'm not
sure getopt does the same for long options, if not adding another line
to define another name is no problem.
prev parent reply other threads:[~2024-08-14 21:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 17:17 [PATCH v5] btrfs-progs: add --subvol option to mkfs.btrfs Mark Harmstone
2024-08-09 19:31 ` David Sterba
2024-08-10 9:53 ` Goffredo Baroncelli
2024-08-10 22:40 ` Qu Wenruo
2024-08-12 11:42 ` Goffredo Baroncelli
2024-08-12 14:39 ` Mark Harmstone
2024-08-12 22:08 ` Qu Wenruo
2024-08-14 21:57 ` David Sterba
2024-08-14 22:11 ` Qu Wenruo
2024-08-14 22:20 ` David Sterba
2024-08-13 0:52 ` Anand Jain
2024-08-13 10:38 ` Mark Harmstone
2024-08-14 21:47 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814214731.GA25962@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=maharmstone@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox