Re: [PATCH v5] btrfs-progs: add --subvol option to mkfs.btrfs

David Sterba
2024-08-14T21:47:35Z

On Tue, Aug 13, 2024 at 08:52:04AM +0800, Anand Jain wrote:
>
> Nice feature.
>
> >> + OPTLINE("-u|--subvol SUBDIR", "create SUBDIR as subvolume rather than normal directory"),
> >
> > Please mention that it can be specified multiple times.
>
> Nitpick..
>
> Should '--subvol' be '--subvolume' for consistency? use the full names.

For convenience both can be accepted, there are aliases for options. The
subcommand names are recognized if abbreviated and still unique, I'm not
sure getopt does the same for long options, if not adding another line
to define another name is no problem.