From: Josef Bacik <josef@toxicpanda.com>
To: Leo Martins <loemra.dev@gmail.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 2/2] btrfs: move clean up code from btrfs_iget_path to btrfs_read_locked_inode
Date: Wed, 21 Aug 2024 13:27:41 -0400 [thread overview]
Message-ID: <20240821172741.GD1998418@perftesting> (raw)
In-Reply-To: <de700f3115e6fd5fe73985b87bb431c3b7131aee.1724184314.git.loemra.dev@gmail.com>
On Tue, Aug 20, 2024 at 01:13:19PM -0700, Leo Martins wrote:
> Move all the clean up code from btrfs_iget_path to
> btrfs_read_locked_inode. I had to move btrfs_add_inode_to_root as it
> needs to be called by btrfs_read_locked_inode, but made no changes
> to it.
Same comment as the other patch, missing your SoB, and the title is too long and
it wrapped. Thanks,
Josef
prev parent reply other threads:[~2024-08-21 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 20:13 [PATCH v2 0/2] btrfs: clean up btrfs_iget, btrfs_iget_path usage Leo Martins
2024-08-20 20:13 ` [PATCH v2 1/2] btrfs: remove conditional path allocation from read_locked_inode, add path allocation to iget Leo Martins
2024-08-21 17:19 ` Josef Bacik
2024-08-21 17:27 ` Josef Bacik
2024-08-20 20:13 ` [PATCH v2 2/2] btrfs: move clean up code from btrfs_iget_path to btrfs_read_locked_inode Leo Martins
2024-08-21 17:27 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821172741.GD1998418@perftesting \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=loemra.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).