From: Josef Bacik <josef@toxicpanda.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] btrfs: initialize last_extent_end to fix -Wmaybe-uninitialized warning in extent_fiemap()
Date: Wed, 21 Aug 2024 13:29:32 -0400 [thread overview]
Message-ID: <20240821172932.GE1998418@perftesting> (raw)
In-Reply-To: <20240820233132.24652-1-dsterba@suse.com>
On Wed, Aug 21, 2024 at 01:31:32AM +0200, David Sterba wrote:
> There's a warning (probably on some older compiler version):
>
> fs/btrfs/fiemap.c: warning: 'last_extent_end' may be used uninitialized in this function [-Wmaybe-uninitialized]: => 822:19
>
> Initialize the variable to 0 although it's not necessary as it's either
> properly set or not used after an error. The called function is in the
> same file so this is a false alert but we want to fix all
> -Wmaybe-uninitialized reports.
>
> Link: https://lore.kernel.org/all/20240819070639.2558629-1-geert@linux-m68k.org/
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
prev parent reply other threads:[~2024-08-21 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 23:31 [PATCH] btrfs: initialize last_extent_end to fix -Wmaybe-uninitialized warning in extent_fiemap() David Sterba
2024-08-21 17:29 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821172932.GE1998418@perftesting \
--to=josef@toxicpanda.com \
--cc=dsterba@suse.com \
--cc=geert@linux-m68k.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox