From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: reduce extent map lookup overhead for data write
Date: Thu, 29 Aug 2024 20:00:09 +0200 [thread overview]
Message-ID: <20240829180009.GP25962@twin.jikos.cz> (raw)
In-Reply-To: <cover.1723096922.git.wqu@suse.com>
On Thu, Aug 08, 2024 at 03:35:58PM +0930, Qu Wenruo wrote:
> Unlike data read path, which use cached extent map to reduce overhead,
> data write path always do the extent map lookup no matter what.
>
> So this patchset will improve the situation by:
>
> - Move em_cached into bio_ctrl
> Since the lifespan of them is the same, it's a perfect match.
>
> - Make data write path to use bio_ctrl::em_cached
>
> Unfortunately since my last relocation, I no longer have any dedicated
> storage attached to my VMs (my laptop only has one NVME slot, and my main
> workhorse aarch64 board only has one NVME attached either).
>
> So no benchmark yet, and any extra benchmark would be very appreciated.
>
> Qu Wenruo (2):
> btrfs: introduce extent_map::em_cached member
> btrfs: utilize cached extent map for data writeback
This looks like a good optimization, we're approaching code freeze (next
week) so it would be good to get it merged by then. As it's an
optimization we can also postpone it if you're busy with other things.
next prev parent reply other threads:[~2024-08-29 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 6:05 [PATCH 0/2] btrfs: reduce extent map lookup overhead for data write Qu Wenruo
2024-08-08 6:05 ` [PATCH 1/2] btrfs: introduce extent_map::em_cached member Qu Wenruo
2024-08-08 11:36 ` Filipe Manana
2024-08-08 23:13 ` Qu Wenruo
2024-08-08 6:06 ` [PATCH 2/2] btrfs: utilize cached extent map for data writeback Qu Wenruo
2024-08-08 11:39 ` Filipe Manana
2024-08-08 10:16 ` [PATCH 0/2] btrfs: reduce extent map lookup overhead for data write Filipe Manana
2024-08-29 18:00 ` David Sterba [this message]
2024-08-29 21:40 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829180009.GP25962@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox