From: Riyan Dhiman <riyandhiman14@gmail.com>
To: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Riyan Dhiman <riyandhiman14@gmail.com>
Subject: [PATCH] btrfs: remove redundant stop_loop variable in scrub_stripe()
Date: Thu, 26 Sep 2024 13:20:34 +0530 [thread overview]
Message-ID: <20240926075034.39475-1-riyandhiman14@gmail.com> (raw)
The variable stop_loop was originally introduced in commit
625f1c8dc66d7 (Btrfs: improve the loop of scrub_stripe). It was initialized
to 0 in commit 3b080b2564287 (Btrfs: scrub raid56 stripes in the right way).
However, in a later commit 18d30ab961497 (btrfs: scrub: use scrub_simple_mirror()
to handle RAID56 data stripe scrub), the code that modified stop_loop was removed,
making the variable redundant.
Currently, stop_loop is only initialized with 0 and is never used or modified
within the scrub_stripe() function. As a result, this patch removes the
stop_loop variable to clean up the code and eliminate unnecessary redundancy.
This change has no impact on functionality, as stop_loop was never utilized
in any meaningful way in the final version of the code.
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
---
Compile tested only
fs/btrfs/scrub.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index 3a3427428074..43431065d981 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -2256,7 +2256,6 @@ static noinline_for_stack int scrub_stripe(struct scrub_ctx *sctx,
/* Offset inside the chunk */
u64 offset;
u64 stripe_logical;
- int stop_loop = 0;
/* Extent_path should be released by now. */
ASSERT(sctx->extent_path.nodes[0] == NULL);
@@ -2370,14 +2369,8 @@ static noinline_for_stack int scrub_stripe(struct scrub_ctx *sctx,
logical += increment;
physical += BTRFS_STRIPE_LEN;
spin_lock(&sctx->stat_lock);
- if (stop_loop)
- sctx->stat.last_physical =
- map->stripes[stripe_index].physical + dev_stripe_len;
- else
- sctx->stat.last_physical = physical;
+ sctx->stat.last_physical = physical;
spin_unlock(&sctx->stat_lock);
- if (stop_loop)
- break;
}
out:
ret2 = flush_scrub_stripes(sctx);
--
2.46.1
next reply other threads:[~2024-09-26 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 7:50 Riyan Dhiman [this message]
2024-09-26 9:50 ` [PATCH] btrfs: remove redundant stop_loop variable in scrub_stripe() Filipe Manana
2024-10-01 15:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926075034.39475-1-riyandhiman14@gmail.com \
--to=riyandhiman14@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox