From: Johannes Thumshirn <jth@kernel.org>
To: David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 0/2] btrfs: RST scrub fixes for prealloc
Date: Mon, 7 Oct 2024 13:52:46 +0200 [thread overview]
Message-ID: <20241007115248.16434-1-jth@kernel.org> (raw)
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
When scrubbing a non-zoned RAID stripe tree filesystem, the RST specific scrub
code finds false positives becuase preallocated extents are not backed by the
stripe-tree and so the lookup failes.
These patches address the issue by a) changing RST lookup failures from
ENOENT to ENODATA and b) skipping ENODATA on RST mapping errors from the scrub
side.
This aproach was suggested by Josef in
https://lore.kernel.org/linux-btrfs/20240923152705.GB159452@perftesting/
Johannes Thumshirn (2):
btrfs: return ENODATA in case RST lookup fails
btrfs: scrub: skip initial RAID stripe-tree lookup errors
fs/btrfs/raid-stripe-tree.c | 6 +++---
fs/btrfs/scrub.c | 6 ++++--
2 files changed, 7 insertions(+), 5 deletions(-)
--
2.43.0
next reply other threads:[~2024-10-07 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 11:52 Johannes Thumshirn [this message]
2024-10-07 11:52 ` [PATCH 1/2] btrfs: return ENODATA in case RST lookup fails Johannes Thumshirn
2024-10-07 11:52 ` [PATCH 2/2] btrfs: scrub: skip initial RAID stripe-tree lookup errors Johannes Thumshirn
2024-10-08 17:05 ` David Sterba
2024-10-07 15:02 ` [PATCH 0/2] btrfs: RST scrub fixes for prealloc Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007115248.16434-1-jth@kernel.org \
--to=jth@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).