From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org, wqu@suse.com, hch@lst.de
Subject: Re: [PATCH] btrfs: fix error propagation of split bios
Date: Thu, 10 Oct 2024 09:06:20 +0200 [thread overview]
Message-ID: <20241010070620.GC6674@lst.de> (raw)
In-Reply-To: <8f76a524-aa49-46b2-aa44-33f92fcd00a5@gmx.com>
On Thu, Oct 10, 2024 at 09:41:04AM +1030, Qu Wenruo wrote:
> My bad, this is not possible.
>
> The original bio will have 1 as __bi_remaining as the initial value.
>
> So even if the cloned one is finished first, the __bi_remaining will
> only stay at 1, not reaching 0, so the original bio will not finish,
> thus impossible to free the original bio.
>
> I need to dig further deeper to find out why the NULL pointer
> dereference happens.
Yes, that was my assumption when writing this code. So I'd love
to understand what is going on here, as it might indicate deeper
problems with the btrfs_bio lifetime.
next prev parent reply other threads:[~2024-10-10 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 15:57 [PATCH] btrfs: fix error propagation of split bios Naohiro Aota
2024-10-09 16:59 ` David Sterba
2024-10-10 5:51 ` Naohiro Aota
2024-10-10 11:02 ` David Sterba
2024-10-09 21:38 ` Qu Wenruo
2024-10-09 21:40 ` Qu Wenruo
2024-10-09 21:58 ` Qu Wenruo
2024-10-09 23:11 ` Qu Wenruo
2024-10-10 7:06 ` Christoph Hellwig [this message]
2024-10-10 8:53 ` Naohiro Aota
2024-10-10 9:45 ` hch
2024-10-12 6:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010070620.GC6674@lst.de \
--to=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).