Re: [PATCH] btrfs: fix error propagation of split bios

[kernel test robot <lkp@intel.com>]

Hi Naohiro,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kdave/for-next]
[also build test WARNING on linus/master v6.12-rc2 next-20241011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Naohiro-Aota/btrfs-fix-error-propagation-of-split-bios/20241010-001915
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link:    https://lore.kernel.org/r/db5c272fc27c59ddded5c691373c26458698cb1a.1728489285.git.naohiro.aota%40wdc.com
patch subject: [PATCH] btrfs: fix error propagation of split bios
config: i386-randconfig-061-20241012 (https://download.01.org/0day-ci/archive/20241012/202410121307.AKR3Gyyc-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241012/202410121307.AKR3Gyyc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410121307.AKR3Gyyc-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> fs/btrfs/bio.c:125:65: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int i @@     got restricted blk_status_t [usertype] bi_status @@
   fs/btrfs/bio.c:125:65: sparse:     expected int i
   fs/btrfs/bio.c:125:65: sparse:     got restricted blk_status_t [usertype] bi_status
>> fs/btrfs/bio.c:133:45: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted blk_status_t [usertype] bi_status @@     got int @@
   fs/btrfs/bio.c:133:45: sparse:     expected restricted blk_status_t [usertype] bi_status
   fs/btrfs/bio.c:133:45: sparse:     got int

vim +125 fs/btrfs/bio.c

   116	
   117	void btrfs_bio_end_io(struct btrfs_bio *bbio, blk_status_t status)
   118	{
   119		bbio->bio.bi_status = status;
   120		if (bbio->bio.bi_pool == &btrfs_clone_bioset) {
   121			struct btrfs_bio *orig_bbio = bbio->private;
   122	
   123			/* Save the last error. */
   124			if (bbio->bio.bi_status != BLK_STS_OK)
 > 125				atomic_set(&orig_bbio->status, bbio->bio.bi_status);
   126			btrfs_cleanup_bio(bbio);
   127			bbio = orig_bbio;
   128		}
   129	
   130		if (atomic_dec_and_test(&bbio->pending_ios)) {
   131			/* Load split bio's error which might be set above. */
   132			if (status == BLK_STS_OK)
 > 133				bbio->bio.bi_status = atomic_read(&bbio->status);
   134			__btrfs_bio_end_io(bbio);
   135		}
   136	}
   137	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki