From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Johannes Thumshirn <jth@kernel.org>,
linux-btrfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Filipe Manana <fdmanana@suse.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH v5 2/2] btrfs: implement self-tests for partial RAID srtipe-tree delete
Date: Wed, 23 Oct 2024 20:53:32 +0200 [thread overview]
Message-ID: <20241023185332.GE31418@suse.cz> (raw)
In-Reply-To: <CAL3q7H7houfrJjOOnmpA6T4xQDa-y1AqsA1AKBQZuOV4ygUVMA@mail.gmail.com>
On Wed, Oct 23, 2024 at 06:45:49PM +0100, Filipe Manana wrote:
> On Wed, Oct 23, 2024 at 2:25 PM Johannes Thumshirn <jth@kernel.org> wrote:
> > + &io_stripe);
> > + if (!ret) {
> > + ret = -EINVAL;
> > + test_err("lookup of RAID extent [%llu, %llu] succeeded, should fail",
> > + logical, logical + SZ_32K);
> > + goto out;
> > + }
> > +
> > + ret = btrfs_delete_raid_extent(trans, logical + SZ_32K, SZ_32K);
> > + btrfs_put_bioc(bioc);
> > + out:
>
> The btrfs_put_bioc(bioc) call needs to be put under the 'out' label,
> otherwise we will leak it in case an error happens.
> It is correct in the next test function, but not in this one.
Fixed in for-next, thanks.
next prev parent reply other threads:[~2024-10-23 18:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 13:25 [PATCH v5 0/2] implement truncation for RAID stripe-extents Johannes Thumshirn
2024-10-23 13:25 ` [PATCH v5 1/2] btrfs: implement partial deletion of RAID stripe extents Johannes Thumshirn
2024-10-23 13:46 ` Filipe Manana
2024-10-23 13:25 ` [PATCH v5 2/2] btrfs: implement self-tests for partial RAID srtipe-tree delete Johannes Thumshirn
2024-10-23 17:45 ` Filipe Manana
2024-10-23 18:53 ` David Sterba [this message]
2024-10-24 7:50 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023185332.GE31418@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox