From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/4] block: fix bio_split_rw_at to take zone_write_granularity into account
Date: Fri, 1 Nov 2024 06:47:59 +0100 [thread overview]
Message-ID: <20241101054759.GA13514@lst.de> (raw)
In-Reply-To: <a7b87e01-045e-423e-854d-4707f9102c75@kernel.org>
On Fri, Nov 01, 2024 at 02:34:31PM +0900, Damien Le Moal wrote:
> > - bytes = ALIGN_DOWN(bytes, lim->logical_block_size);
> > + bytes = ALIGN_DOWN(bytes, lim->zone_write_granularity ?
> > + lim->zone_write_granularity : lim->logical_block_size);
>
> Nit: we could also do:
>
> bytes = ALIGN_DOWN(bytes,
> max(lim->logical_block_size, lim->zone_write_granularity));
That's what I had first. It is a little odd as zone_write_granularity
is defined to be >= logical_block_size, though.
> Also, I wonder if we should leave read split as is based on the logical block
> size only ? Probably does not matter much...
Good point. Probably doesn't matter much, but randomly forcing it on
reads seems odd.
next prev parent reply other threads:[~2024-11-01 5:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 5:21 fix a few zoned append issues Christoph Hellwig
2024-11-01 5:21 ` [PATCH 1/4] block: fix bio_split_rw_at to take zone_write_granularity into account Christoph Hellwig
2024-11-01 5:34 ` Damien Le Moal
2024-11-01 5:47 ` Christoph Hellwig [this message]
2024-11-01 5:21 ` [PATCH 2/4] block: lift bio_is_zone_append to bio.h Christoph Hellwig
2024-11-01 5:37 ` Damien Le Moal
2024-11-01 5:48 ` Christoph Hellwig
2024-11-04 10:44 ` Johannes Thumshirn
2024-11-01 5:21 ` [PATCH 3/4] btrfs: use bio_is_zone_append in the completion handler Christoph Hellwig
2024-11-01 5:38 ` Damien Le Moal
2024-11-04 10:45 ` Johannes Thumshirn
2024-11-05 6:09 ` Naohiro Aota
2024-11-01 5:21 ` [PATCH 4/4] btrfs: split bios to the fs sector size boundary Christoph Hellwig
2024-11-01 5:40 ` Damien Le Moal
2024-11-04 10:45 ` Johannes Thumshirn
2024-11-05 6:00 ` Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101054759.GA13514@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox