From: David Sterba <dsterba@suse.cz>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Allison Karlitskaya <allison.karlitskaya@redhat.com>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
linux-btrfs@vger.kernel.org, fsverity@lists.linux.dev
Subject: Re: [PATCH] btrfs: add FS_IOC_READ_VERITY_METADATA ioctl
Date: Tue, 26 Nov 2024 16:11:23 +0100 [thread overview]
Message-ID: <20241126151123.GF31418@twin.jikos.cz> (raw)
In-Reply-To: <20241126023313.GA3095319@google.com>
On Tue, Nov 26, 2024 at 02:33:13AM +0000, Eric Biggers wrote:
> On Mon, Nov 25, 2024 at 09:06:25PM +0100, Allison Karlitskaya wrote:
> > hi Eric,
> >
> > Thanks for the reply.
> >
> > On Mon, 25 Nov 2024 at 19:11, Eric Biggers <ebiggers@kernel.org> wrote:
> > > At the time, btrfs did not support fs-verity.
> >
> > Oops. I missed that detail. :) I wonder why they did the
> > implementation without the metadata ioctl, then...
> >
> > Would you like me to change the commit message? (or feel free to do
> > it yourself...)
>
> Please go ahead and update it. Thanks!
>
> BTW, I recommend that this be taken through the btrfs tree.
Yes this should go through our tree. Thanks for the patch and
evaluation. I've noticed one patch in fstests being skipped due to the
missing ioctl. Nobody knows why it wasn't added or what it could be
useful for but as there is a use case then we'll add it.
next prev parent reply other threads:[~2024-11-26 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 8:41 [PATCH] btrfs: add FS_IOC_READ_VERITY_METADATA ioctl Allison Karlitskaya
2024-11-25 18:11 ` Eric Biggers
2024-11-25 20:06 ` Allison Karlitskaya
2024-11-26 2:33 ` Eric Biggers
2024-11-26 15:11 ` David Sterba [this message]
2024-11-26 15:23 ` Allison Karlitskaya
2024-11-26 16:23 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126151123.GF31418@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=allison.karlitskaya@redhat.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=linux-btrfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox