From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48CA33398B for ; Tue, 3 Dec 2024 04:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733201604; cv=none; b=g8ogt8Lc+Py8GjiIFY6QuQ1Bi7ueao5Tp2xzzr7FaaBNNt9mKN64k4B4dmi2KXj4PJWkDYSajGmv3i2/HX/o8lYUmmuWpdWjB9LOCjOYjXkEABtDLn8wf5ymMOTszxEGEGiNqOkDYsOdn/jO7XpdJ1oGc4ZGK0XUdKON1Hc7TVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733201604; c=relaxed/simple; bh=0KsSD6/gGZzrPhSalHZ6xisU7WTmNye1JLjt4MKbs9w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ECp/JBXN+WrZ08jXobu1YRHp0UaQeHkx88WQNMwfdCt3HJBVnJPlursTUJXTsFRqeSe64hsPqssC/reLMvgBzDPTXqfxMRXqyQBI5Ebeej5oP5W78kgxVH/UyL8s1OBdHja/7Sri27dVBkww0TSzPx/kcTYry0MKR6ETFxwjfzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=Xe2gGOEH; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=gmdcU+l4; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=Xe2gGOEH; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=gmdcU+l4; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="Xe2gGOEH"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="gmdcU+l4"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="Xe2gGOEH"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="gmdcU+l4" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 59F1D1F445; Tue, 3 Dec 2024 04:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733201598; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KsSD6/gGZzrPhSalHZ6xisU7WTmNye1JLjt4MKbs9w=; b=Xe2gGOEHzocbi8bQVWzW4yT1K8vFuclOf9PV52jVyDqUQxKgSnoRhHR8I3w/6Vyc/f2eiu roW5+oVYliocj7IRWrKBP4bT0rW7SPLyfgIGfJu3dsvfgRXG2hK5LsHkETG4CrMA33nojf F/zOD1doeFnXqUqkTzoRrK7XKKyVMRo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733201598; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KsSD6/gGZzrPhSalHZ6xisU7WTmNye1JLjt4MKbs9w=; b=gmdcU+l4tgqLdYr+fwl10spRlSaa3CjgYRMKuO6CTgdI9MDiSFpuVxhGypD39l8X3ppXq6 MFP/9MGc/I1YYADw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733201598; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KsSD6/gGZzrPhSalHZ6xisU7WTmNye1JLjt4MKbs9w=; b=Xe2gGOEHzocbi8bQVWzW4yT1K8vFuclOf9PV52jVyDqUQxKgSnoRhHR8I3w/6Vyc/f2eiu roW5+oVYliocj7IRWrKBP4bT0rW7SPLyfgIGfJu3dsvfgRXG2hK5LsHkETG4CrMA33nojf F/zOD1doeFnXqUqkTzoRrK7XKKyVMRo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733201598; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KsSD6/gGZzrPhSalHZ6xisU7WTmNye1JLjt4MKbs9w=; b=gmdcU+l4tgqLdYr+fwl10spRlSaa3CjgYRMKuO6CTgdI9MDiSFpuVxhGypD39l8X3ppXq6 MFP/9MGc/I1YYADw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3A10C139C2; Tue, 3 Dec 2024 04:53:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XWMCDb6OTmceBQAAD6G6ig (envelope-from ); Tue, 03 Dec 2024 04:53:18 +0000 Date: Tue, 3 Dec 2024 05:53:10 +0100 From: Petr Vorel To: Cyril Hrubis Cc: Zorro Lang , ltp@lists.linux.it, linux-btrfs@vger.kernel.org Subject: Re: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero Message-ID: <20241203045310.GA414034@pevik> Reply-To: Petr Vorel References: <20241201093606.68993-1-zlang@kernel.org> <20241201093606.68993-2-zlang@kernel.org> <20241202144208.GB321427@pevik> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -7.50 X-Spamd-Result: default: False [-7.50 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Spam-Flag: NO X-Spam-Level: > Hi! > > It's a nice feature to be able to force testing on filesystem even it's set to > > be skipped without need to manually enable the filesystem and recompile. > > (It helps testing with LTP compiled as a package without need to compile LTP.) > > Therefore I would avoid this. > I guess that this should be another env variable e.g. > LTP_FORCE_SINGLE_FS_TYPE and it should print a big fat warning that it's > only for development purposes. Well, LTP_SINGLE_FS_TYPE already has "Testing only" and that was the reason it just forced filesystem regardless "skip" setup. Sure, we can turn it into "normal" variable and introduce LTP_FORCE_SINGLE_FS_TYPE if it's needed. But that would be an use case if anybody uses LTP really to test particular filesystem. And it would affect only .all_filesystem tests (e.g. user's responsibility would be to point TMPDIR to that particular system on non- .all_filesystem tests). @Zorro was it meant like this? Kind regards, Petr