Re: [PATCH 2/2] btrfs: add delayed ref self tests

[Josef Bacik <josef@toxicpanda.com>]

On Fri, Dec 06, 2024 at 08:51:00PM +0100, David Sterba wrote:
> On Fri, Nov 15, 2024 at 07:33:05PM +0100, David Sterba wrote:
> > On Thu, Nov 14, 2024 at 02:57:49PM -0500, Josef Bacik wrote:
> > > +	node_check.root = FAKE_ROOT_OBJECTID;
> > > +	if (validate_ref_node(node, &node_check)) {
> > > +		test_err("node check failed");
> > > +		goto out;
> > > +	}
> > > +	delete_delayed_ref_node(head, node);
> > > +	ret = 0;
> > > +out:
> > > +	if (head)
> > > +		btrfs_unselect_ref_head(delayed_refs, head);
> > > +	btrfs_destroy_delayed_refs(trans->transaction);
> > > +	return ret;
> > > +}
> > > +
> > > +int btrfs_test_delayed_refs(u32 sectorsize, u32 nodesize)
> > > +{
> > > +	struct btrfs_transaction transaction;
> > > +	struct btrfs_trans_handle trans;
> > 
> > Build complains
> > 
> >   CC [M]  fs/btrfs/tests/delayed-refs-tests.o
> > fs/btrfs/tests/delayed-refs-tests.c: In function ‘btrfs_test_delayed_refs’:
> > fs/btrfs/tests/delayed-refs-tests.c:1012:1: warning: the frame size of 2056 bytes is larger than 2048 bytes [-Wframe-larger-than=]
> > 
> > Please change that to kmalloc so we don't get warning reports on configs that
> > bloat data structures. On release config the sizes are like 480 + 168, which is ok.
> 
> Fixed in for-next.

Aaaand you're cleaning up all my messes, thanks for this,

Josef