From: Josef Bacik <josef@toxicpanda.com>
To: "Roger L. Beckermeyer III" <beckerlee3@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCHi 0/6] reduce boilerplate code within btrfs
Date: Mon, 9 Dec 2024 09:05:06 -0500 [thread overview]
Message-ID: <20241209140506.GD2840216@perftesting> (raw)
In-Reply-To: <cover.1733695544.git.beckerlee3@gmail.com>
On Sun, Dec 08, 2024 at 04:37:59PM -0600, Roger L. Beckermeyer III wrote:
> The goal of this patch series is to reduce boilerplate code
> within btrfs. To accomplish this rb_find_add_cached() was added
> to linux/include/rbtree.h. Any replaceable functions were then
> replaced within btrfs.
>
Just a few overall comments on the whole series:
1) Make sure you fix up all the kbuilder test bot things.
2) Don't add "Reviewed-by" or "Tested-by" tags to your own patches, that's for
other people to do. Generally we use "Tested-by" for people who have tested
a specific bug fix.
Thanks,
Josef
next prev parent reply other threads:[~2024-12-09 14:05 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 22:37 [PATCHi 0/6] reduce boilerplate code within btrfs Roger L. Beckermeyer III
2024-12-08 22:38 ` [PATCH] rbtree: add rb_find_add_cached() to rbtree.h Roger L. Beckermeyer III
2024-12-08 22:38 ` [PATCH] btrfs: edit btrfs_add_block_group_cache() to use rb helper Roger L. Beckermeyer III
2024-12-09 5:05 ` kernel test robot
2024-12-08 22:38 ` [PATCH] btrfs: edit prelim_ref_insert() to use rb helpers Roger L. Beckermeyer III
2024-12-09 5:02 ` kernel test robot
2024-12-09 5:06 ` kernel test robot
2024-12-08 22:38 ` [PATCH] btrfs: edit __btrfs_add_delayed_item() to use rb helper Roger L. Beckermeyer III
2024-12-09 5:00 ` kernel test robot
2024-12-09 5:07 ` kernel test robot
2024-12-12 1:18 ` kernel test robot
2024-12-08 22:38 ` [PATCH] btrfs: edit btrfs_add_chunk_map() to use rb helpers Roger L. Beckermeyer III
2024-12-09 5:05 ` kernel test robot
2024-12-09 5:07 ` kernel test robot
2024-12-08 22:38 ` [PATCH] btrfs: edits tree_insert() " Roger L. Beckermeyer III
2024-12-09 5:04 ` kernel test robot
2024-12-09 5:08 ` kernel test robot
2024-12-09 12:36 ` kernel test robot
2024-12-09 12:46 ` Filipe Manana
2024-12-11 22:17 ` kernel test robot
2024-12-09 6:10 ` [PATCHi 0/6] reduce boilerplate code within btrfs Qu Wenruo
2024-12-09 14:05 ` Josef Bacik [this message]
2024-12-10 19:06 ` [PATCH " Roger L. Beckermeyer III
2024-12-10 19:06 ` [PATCH 1/6] rbtree: add rb_find_add_cached() to rbtree.h Roger L. Beckermeyer III
2024-12-10 19:58 ` Johannes Thumshirn
2024-12-11 17:47 ` Roger L. Beckermeyer III
2024-12-11 18:41 ` David Sterba
2024-12-12 16:46 ` Roger L. Beckermeyer III
2024-12-13 7:21 ` Qu Wenruo
2024-12-13 9:05 ` Peter Zijlstra
2024-12-13 9:06 ` Peter Zijlstra
2024-12-16 22:13 ` Qu Wenruo
2024-12-16 22:22 ` Peter Zijlstra
2024-12-16 22:40 ` Qu Wenruo
2024-12-10 19:06 ` [PATCH 2/6] btrfs: edit btrfs_add_block_group_cache() to use rb helper Roger L. Beckermeyer III
2024-12-11 18:45 ` David Sterba
2024-12-11 18:49 ` David Sterba
2024-12-10 19:06 ` [PATCH 3/6] btrfs: edit prelim_ref_insert() to use rb helpers Roger L. Beckermeyer III
2024-12-11 18:47 ` David Sterba
2024-12-10 19:06 ` [PATCH 4/6] btrfs: edit __btrfs_add_delayed_item() to use rb helper Roger L. Beckermeyer III
2024-12-10 19:06 ` [PATCH 5/6] btrfs: edit btrfs_add_chunk_map() to use rb helpers Roger L. Beckermeyer III
2024-12-10 19:06 ` [PATCH 6/6] btrfs: edit tree_insert() " Roger L. Beckermeyer III
2024-12-12 20:29 ` [PATCH 0/6] reduce boilerplate code within btrfs Roger L. Beckermeyer III
2024-12-12 20:29 ` [PATCH 2/6] btrfs: update btrfs_add_block_group_cache() to use rb helpers Roger L. Beckermeyer III
2024-12-13 7:19 ` Qu Wenruo
2024-12-12 20:29 ` [PATCH 3/6] btrfs: update prelim_ref_insert() " Roger L. Beckermeyer III
2024-12-12 20:29 ` [PATCH 4/6] btrfs: update __btrfs_add_delayed_item() " Roger L. Beckermeyer III
2024-12-12 20:29 ` [PATCH 5/6] btrfs: update btrfs_add_chunk_map() " Roger L. Beckermeyer III
2024-12-12 20:29 ` [PATCH 6/6] btrfs: update tree_insert() " Roger L. Beckermeyer III
2024-12-13 6:19 ` Qu Wenruo
2024-12-13 7:30 ` Johannes Thumshirn
2024-12-13 7:32 ` Qu Wenruo
2024-12-13 17:14 ` Lee Beckermeyer
2024-12-13 20:28 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209140506.GD2840216@perftesting \
--to=josef@toxicpanda.com \
--cc=beckerlee3@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox