From: "Darrick J. Wong" <djwong@kernel.org>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] generic: test swap activation on file that used to have clones
Date: Tue, 17 Dec 2024 09:22:23 -0800 [thread overview]
Message-ID: <20241217172223.GA6160@frogsfrogsfrogs> (raw)
In-Reply-To: <CAL3q7H4Age-k0ifGh+n4QwExC1vTgWGd3NROcX40vQXKRipBqw@mail.gmail.com>
On Tue, Dec 17, 2024 at 08:26:33AM +0000, Filipe Manana wrote:
> On Tue, Dec 17, 2024 at 8:14 AM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Wed, Dec 11, 2024 at 03:09:40PM +0000, fdmanana@kernel.org wrote:
> > > The test also fails sporadically on xfs and the bug was already reported
> > > to the xfs mailing list:
> > >
> > > https://lore.kernel.org/linux-xfs/CAL3q7H7cURmnkJfUUx44HM3q=xKmqHb80eRdisErD_x8rU4+0Q@mail.gmail.com/
> > >
> >
> > This version still doesn't seem to have the fs freeze/unfreeze that Darrick
> > asked for in that thread.
>
> I don't get it, what's the freeze/unfreeze for? Where should they be placed?
> Is it some way to get around the bug on xfs?
freeze kicks the background inode gc thread so that the unlinked clones
actually get freed before the swapon call. A less bighammer idea might
be to call XFS_IOC_FREE_EOFBLOCKS which also kicks the garbage
collectors.
--D
next prev parent reply other threads:[~2024-12-17 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 15:09 [PATCH] generic: test swap activation on file that used to have clones fdmanana
2024-12-17 8:14 ` Christoph Hellwig
2024-12-17 8:26 ` Filipe Manana
2024-12-17 17:22 ` Darrick J. Wong [this message]
2024-12-17 17:41 ` Filipe Manana
2024-12-17 22:37 ` Qu Wenruo
2024-12-18 20:09 ` Darrick J. Wong
2024-12-18 20:19 ` Qu Wenruo
2025-01-13 12:00 ` Filipe Manana
2025-01-13 13:24 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217172223.GA6160@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox