Re: [PATCH 2/3] btrfs: Fix two misuses of folio_shift()

[David Sterba <dsterba@suse.cz>]

On Fri, Jan 24, 2025 at 04:41:46PM +1030, Qu Wenruo wrote:
> 
> 
> 在 2025/1/23 01:54, David Sterba 写道:
> > On Tue, Jan 21, 2025 at 05:59:53PM +0000, Matthew Wilcox wrote:
> >>>>> +			if (folio_contains(folio, i_size >> PAGE_SHIFT) &&
> >>>>
> >>>> Although folio_contains() is already a pretty good improvement, can we
> >>>> have a bytenr/i_sized based solution for fs usages?
> >>>
> >>> Good point, something like folio_contains_offset() that does the correct
> >>> shifts.
> >>
> >> I'd call it folio_contains_pos(), but I'm not sure there's a lot of
> >> users.  We've got a lot of filesystems converted now, and btrfs is the
> >> first one to want something like that.  I've had a look through iomap
> >> and some other filesystems, and I can't see anywhere else that would use
> >> folio_contains_pos().
> >
> > Ok then, we can live with that, but please keep it in mind for future
> > folio API updates. Thanks.
> >
> Then the whole series looks good to me.
> 
> Reviewed-by: Qu Wenruo <wqu@suse.com>
> 
> And since the whole series is reviewed, should I merge this series into
> for-next now?

Yes please.