From: David Sterba <dsterba@suse.cz>
To: Racz Zoli <racz.zoli@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] Removed redundant if/else statement
Date: Wed, 12 Feb 2025 00:42:48 +0100 [thread overview]
Message-ID: <20250211234248.GW5777@suse.cz> (raw)
In-Reply-To: <CANoGd8mhGau83LU-bWjyi-A2jnzZoAyhqzo3yuxnhC2sETpfWw@mail.gmail.com>
On Tue, Feb 11, 2025 at 09:31:33PM +0200, Racz Zoli wrote:
> I simplified that if/else block because looking at it it seemed the
> only difference between the two was that in the if block
> pretty_size_mode received UNITS_RAW and in else it received unit_mode.
> Didn`t know about the underlying reason you mentioned.
> But if the second patch containing the json output implementation is
> ok, I can rewrite it so it uses the function as it was before my
> commit.
I have fixed the unit printing and found another bug. Please base your
commit on current devel branch. The json patch won't apply cleanly but
it's only in the rate printing part.
next prev parent reply other threads:[~2025-02-11 23:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 2:33 [PATCH 0/2] btrfs-progs: scrub status: add json output format Racz Zoltan
2025-02-07 2:33 ` [PATCH 1/2] Removed redundant if/else statement Racz Zoltan
2025-02-11 19:14 ` David Sterba
2025-02-11 19:31 ` Racz Zoli
2025-02-11 23:42 ` David Sterba [this message]
2025-02-13 19:49 ` Racz Zoli
2025-02-07 2:33 ` [PATCH 2/2] scrub status: add json output format Racz Zoltan
2025-02-11 19:41 ` David Sterba
2025-02-11 23:37 ` Racz Zoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211234248.GW5777@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=racz.zoli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox