From: kernel test robot <lkp@intel.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 4/8] btrfs: make btrfs_iget() return a btrfs inode instead
Date: Sun, 9 Mar 2025 01:48:25 +0800 [thread overview]
Message-ID: <202503090344.SeJrOfHD-lkp@intel.com> (raw)
In-Reply-To: <f6d2a09fb43742fb5be38f820908510e298f8d40.1741354479.git.fdmanana@suse.com>
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on kdave/for-next]
[also build test ERROR on next-20250307]
[cannot apply to linus/master v6.14-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/fdmanana-kernel-org/btrfs-return-a-btrfs_inode-from-btrfs_iget_logging/20250307-214724
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link: https://lore.kernel.org/r/f6d2a09fb43742fb5be38f820908510e298f8d40.1741354479.git.fdmanana%40suse.com
patch subject: [PATCH 4/8] btrfs: make btrfs_iget() return a btrfs inode instead
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250309/202503090344.SeJrOfHD-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503090344.SeJrOfHD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503090344.SeJrOfHD-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from fs/btrfs/send.c:11:
In file included from include/linux/xattr.h:18:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> fs/btrfs/send.c:5535:8: error: incompatible pointer types assigning to 'struct inode *' from 'struct btrfs_inode *' [-Werror,-Wincompatible-pointer-types]
5535 | inode = btrfs_iget(sctx->cur_ino, root);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 warnings and 1 error generated.
vim +5535 fs/btrfs/send.c
16e7549f045d33b Josef Bacik 2013-10-22 5519
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5520 static int send_encoded_inline_extent(struct send_ctx *sctx,
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5521 struct btrfs_path *path, u64 offset,
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5522 u64 len)
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5523 {
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5524 struct btrfs_root *root = sctx->send_root;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5525 struct btrfs_fs_info *fs_info = root->fs_info;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5526 struct inode *inode;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5527 struct fs_path *fspath;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5528 struct extent_buffer *leaf = path->nodes[0];
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5529 struct btrfs_key key;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5530 struct btrfs_file_extent_item *ei;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5531 u64 ram_bytes;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5532 size_t inline_size;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5533 int ret;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5534
d13240dd0a2d13b Filipe Manana 2024-06-13 @5535 inode = btrfs_iget(sctx->cur_ino, root);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5536 if (IS_ERR(inode))
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5537 return PTR_ERR(inode);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5538
6054b503e2eafac Filipe Manana 2025-02-18 5539 fspath = get_cur_inode_path(sctx);
6054b503e2eafac Filipe Manana 2025-02-18 5540 if (IS_ERR(fspath)) {
6054b503e2eafac Filipe Manana 2025-02-18 5541 ret = PTR_ERR(fspath);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5542 goto out;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5543 }
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5544
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5545 ret = begin_cmd(sctx, BTRFS_SEND_C_ENCODED_WRITE);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5546 if (ret < 0)
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5547 goto out;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5548
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5549 btrfs_item_key_to_cpu(leaf, &key, path->slots[0]);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5550 ei = btrfs_item_ptr(leaf, path->slots[0], struct btrfs_file_extent_item);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5551 ram_bytes = btrfs_file_extent_ram_bytes(leaf, ei);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5552 inline_size = btrfs_file_extent_inline_item_len(leaf, path->slots[0]);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5553
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5554 TLV_PUT_PATH(sctx, BTRFS_SEND_A_PATH, fspath);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5555 TLV_PUT_U64(sctx, BTRFS_SEND_A_FILE_OFFSET, offset);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5556 TLV_PUT_U64(sctx, BTRFS_SEND_A_UNENCODED_FILE_LEN,
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5557 min(key.offset + ram_bytes - offset, len));
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5558 TLV_PUT_U64(sctx, BTRFS_SEND_A_UNENCODED_LEN, ram_bytes);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5559 TLV_PUT_U64(sctx, BTRFS_SEND_A_UNENCODED_OFFSET, offset - key.offset);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5560 ret = btrfs_encoded_io_compression_from_extent(fs_info,
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5561 btrfs_file_extent_compression(leaf, ei));
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5562 if (ret < 0)
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5563 goto out;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5564 TLV_PUT_U32(sctx, BTRFS_SEND_A_COMPRESSION, ret);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5565
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5566 ret = put_data_header(sctx, inline_size);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5567 if (ret < 0)
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5568 goto out;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5569 read_extent_buffer(leaf, sctx->send_buf + sctx->send_size,
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5570 btrfs_file_extent_inline_start(ei), inline_size);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5571 sctx->send_size += inline_size;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5572
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5573 ret = send_cmd(sctx);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5574
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5575 tlv_put_failure:
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5576 out:
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5577 iput(inode);
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5578 return ret;
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5579 }
3ea4dc5bf00c7d1 Omar Sandoval 2022-03-17 5580
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-03-08 17:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 13:44 [PATCH 0/8] btrfs: some trivial cleanups fdmanana
2025-03-07 13:44 ` [PATCH 1/8] btrfs: return a btrfs_inode from btrfs_iget_logging() fdmanana
2025-03-07 13:44 ` [PATCH 2/8] btrfs: return a btrfs_inode from read_one_inode() fdmanana
2025-03-07 13:44 ` [PATCH 3/8] btrfs: pass a btrfs_inode to fixup_inode_link_count() fdmanana
2025-03-07 13:44 ` [PATCH 4/8] btrfs: make btrfs_iget() return a btrfs inode instead fdmanana
2025-03-08 15:31 ` kernel test robot
2025-03-10 10:45 ` Filipe Manana
2025-03-11 9:40 ` Philip Li
2025-03-08 17:48 ` kernel test robot [this message]
2025-03-10 10:46 ` Filipe Manana
2025-03-07 13:44 ` [PATCH 5/8] btrfs: make btrfs_iget_path() " fdmanana
2025-03-07 13:44 ` [PATCH 6/8] btrfs: remove unnecessary fs_info argument from create_reloc_inode() fdmanana
2025-03-07 13:44 ` [PATCH 7/8] btrfs: remove unnecessary fs_info argument from delete_block_group_cache() fdmanana
2025-03-07 13:44 ` [PATCH 8/8] btrfs: remove unnecessary fs_info argument from btrfs_add_block_group_cache() fdmanana
2025-03-10 18:42 ` [PATCH 0/8] btrfs: some trivial cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503090344.SeJrOfHD-lkp@intel.com \
--to=lkp@intel.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox