From: Josef Bacik <josef@toxicpanda.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [GIT PULL] Btrfs updates for 6.15
Date: Fri, 28 Mar 2025 09:27:51 -0400 [thread overview]
Message-ID: <20250328132751.GA1379678@perftesting> (raw)
In-Reply-To: <cover.1742834133.git.dsterba@suse.com>
On Mon, Mar 24, 2025 at 05:37:51PM +0100, David Sterba wrote:
> Hi,
>
> please pull the following btrfs updates, thanks.
>
> User visible changes:
>
> - fall back to buffered write if direct io is done on a file that requires
> checksums
<trimming the everybody linux-btrfs from the cc list>
What? We use this constantly in a bunch of places to avoid page cache overhead,
it's perfectly legitimate to do DIO to a file that requires checksums. Does the
vm case mess this up? Absolutely, but that's why we say use NOCOW for that
case. We've always had this behavior, we've always been clear that if you break
it you buy it. This is a huge regression for a pretty significant use case.
Thanks,
Josef
next prev parent reply other threads:[~2025-03-28 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 16:37 [GIT PULL] Btrfs updates for 6.15 David Sterba
2025-03-27 20:48 ` pr-tracker-bot
2025-03-28 13:27 ` Josef Bacik [this message]
2025-03-28 17:36 ` David Sterba
2025-03-28 19:39 ` Josef Bacik
2025-03-28 21:36 ` Qu Wenruo
2025-03-31 9:35 ` Daniel Vacek
2025-03-31 23:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328132751.GA1379678@perftesting \
--to=josef@toxicpanda.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox