From: David Sterba <dsterba@suse.cz>
To: Klara Modin <klarasmodin@gmail.com>
Cc: Daniel Vacek <neelx@suse.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: unlock all extent buffer folios in failure case
Date: Thu, 24 Apr 2025 13:57:57 +0200 [thread overview]
Message-ID: <20250424115757.GM3659@suse.cz> (raw)
In-Reply-To: <6268df0f-e7a5-4b4f-84d0-082f5767f6d7@gmail.com>
On Thu, Apr 24, 2025 at 01:15:24PM +0200, Klara Modin wrote:
>
> Hi,
>
> On Tue, Apr 22, 2025 at 02:57:01PM +0200, Daniel Vacek wrote:
> > When attaching a folio fails, for example if another one is already mapped,
> > we need to unlock all newly allocated folios before putting them. And as a
> > consequence we do not need to flag the eb UNMAPPED anymore.
> >
> > Signed-off-by: Daniel Vacek <neelx@suse.com>
>
> I hit a null pointer dereference in next-20250424 which seems to point
> to this commit. Reverting it resolves the issue for me (did not bisect).
Thanks for the report, the patch has been removed from linux-next
branches.
next prev parent reply other threads:[~2025-04-24 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 12:57 [PATCH] btrfs: unlock all extent buffer folios in failure case Daniel Vacek
2025-04-24 11:09 ` Klara Modin
2025-04-24 11:15 ` Klara Modin
2025-04-24 11:57 ` David Sterba [this message]
2025-04-24 15:08 ` [PATCH v2] btrfs: put all allocated " Daniel Vacek
2025-04-24 18:21 ` Boris Burkov
2025-04-24 18:49 ` Klara Modin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424115757.GM3659@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=klarasmodin@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelx@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox