From: David Sterba <dsterba@suse.cz>
To: Sun YangKai <sunk67188@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: fix nonzero lowest level handling in btrfs_search_forward()
Date: Tue, 29 Apr 2025 17:27:59 +0200 [thread overview]
Message-ID: <20250429152759.GD9140@twin.jikos.cz> (raw)
In-Reply-To: <4649867.LvFx2qVVIh@saltykitkat>
On Tue, Apr 29, 2025 at 02:57:02PM +0800, Sun YangKai wrote:
> Hi maintainers and community,
>
> I'd like to request some feedback on this issue.
>
> Is this behavior not considered a bug, or does it require further work?
>
> Given that this issue never seems to be triggered in the current code base,
> perhaps we could consider cleaning up and removing the lowest_level related
> logic altogether?
I've looked at this a few times and I'm not decided what to do. It's an
old code and works given that we haven't seen any problems so removing
dead code makes sense. OTOH that one function does not pass some
values of parameters does not mean want to remove the implementation
completely. At least some assertions should be added to handle the
case(s) for the removed code if there's a new use.
next prev parent reply other threads:[~2025-04-29 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 12:56 [PATCH v2] btrfs: fix nonzero lowest level handling in btrfs_search_forward() Sun YangKai
2025-04-29 6:57 ` Sun YangKai
2025-04-29 15:27 ` David Sterba [this message]
[not found] ` <6048084.MhkbZ0Pkbq@saltykitkat>
2025-05-17 13:33 ` Sun YangKai
2025-05-17 13:47 ` [PATCH v3] btrfs: remove " Sun YangKai
2025-05-18 11:25 ` Qu Wenruo
[not found] ` <12674804.O9o76ZdvQC@saltykitkat>
[not found] ` <4d02fad5-07b2-47b6-9e18-30f45bc67163@suse.com>
[not found] ` <5890818.DvuYhMxLoT@saltykitkat>
2025-05-19 5:30 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429152759.GD9140@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=sunk67188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox