Re: [PATCH v3] btrfs_get_tree_subvol(): switch from fc_mount() to vfs_create_mount()

David Sterba
2025-06-03T19:38:22Z

On Tue, Jun 03, 2025 at 06:53:47PM +0930, Qu Wenruo wrote:
>
>
> 在 2025/6/3 17:29, David Sterba 写道:
> > On Thu, May 08, 2025 at 06:59:04PM +0930, Qu Wenruo wrote:
> >>
> >>
> >> 在 2025/5/7 05:28, Al Viro 写道:
> >>> [Aaarghh...]
> >>> it's simpler to do btrfs_reconfigure_for_mount() right after vfs_get_tree() -
> >>> no need to mess with ->s_umount.
> >>>
> >>> [fix for braino(s) folded in - kudos to Klara Modin <klarasmodin@gmail.com>]
> >>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> >>
> >> Reviewed-by: Qu Wenruo <wqu@suse.com>
> >> Test-by: Qu Wenruo <wqu@suse.com>
> >>
> >> Although the commit message can be enhanced a little, I can handle it at
> >> merge time, no need to re-send.
> >
> > If you're going to add the patch to for-next, please fix the subject
> > line and update the changelog. Thanks.
> >
>
> I have merged this one to for-next just minutes ago.
>
> However the version I pushed doesn't only have its commit
> message/subject modified, but also modified its error handling, to align
> with our error-first behavior.
> (Which is much easier to read compared to the one in the patch)
>
> So I have sent the updated version to the mail list just for reference.

Perfect, thanks.