Re: [PATCH 1/2] btrfs: Raise nobarrier log level to warn

David Sterba
2025-05-26T09:14:39Z

On Sat, May 24, 2025 at 01:18:58PM +0930, Qu Wenruo wrote:
>
>
> 在 2025/5/24 11:51, Kyoji Ogasawara 写道:
> > Thanks for the explanation. I understand the issue with btrfs_parse_param()
> > being triggered multiple times.
> >
> > If I move the log into btrfs_parse_param(), it would currently use
> > btrfs_info_if_set(),
> > resulting in an info level log.
> >
> > Is an info level acceptable for this warning, or would you prefer a
> > warn level log?
>
> I think info level is good enough.
>
> As the main purpose of that message line is still just to show we're
> using barrier or not, the extra "use with care" is just something good
> to have.
>
> Thus no need to go warning IMHO.

Agreed, info level is the right one. Warn messages are for user/admin
attention and some action may be needed. If somebody intentionally sets
the slightly dangerous options then info is to log that and "you get
what you ask for".