Re: [PATCH v2 2/2] btrfs: don't silently ignore unexpected extent type when replaying log

[Boris Burkov <boris@bur.io>]

On Tue, Jun 03, 2025 at 10:19:58PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> If there's an unexpected (invalid) extent type, we just silently ignore
> it. This means a corruption or some bug somewhere, so instead return
> -EUCLEAN to the caller, making log replay fail, and print an error message
> with relevant information.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Boris Burkov <boris@bur.io>

> ---
>  fs/btrfs/tree-log.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index c8dcc7d3f4b0..3f5593fe1215 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -668,7 +668,10 @@ static noinline int replay_one_extent(struct btrfs_trans_handle *trans,
>  		extent_end = ALIGN(start + size,
>  				   fs_info->sectorsize);
>  	} else {
> -		return 0;
> +		btrfs_err(fs_info,
> +		  "unexpected extent type=%d root=%llu inode=%llu offset=%llu",
> +			  found_type, btrfs_root_id(root), key->objectid, key->offset);
> +		return -EUCLEAN;
>  	}
>  
>  	inode = read_one_inode(root, key->objectid);
> -- 
> 2.47.2
>