From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <jth@kernel.org>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>,
Damien Le Moal <dlemoal@kernel.org>,
Naohiro Aota <naohiro.aota@wdc.com>,
Josef Bacik <josef@toxicpanda.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH] btrfs: add comma delimiter for zone_unusable to space_info dump
Date: Thu, 5 Jun 2025 22:43:35 +0200 [thread overview]
Message-ID: <20250605204335.GT4037@twin.jikos.cz> (raw)
In-Reply-To: <20250605152431.396419-1-jth@kernel.org>
On Thu, Jun 05, 2025 at 05:24:31PM +0200, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>
> On a space_info dump all values but 'zone_unusable' are delimited by a
> comma.
>
> Add the missing comma between 'readonly' and 'zone_unusable' to be
> consistent and make parsing easier.
So this makes it consistent with the rest of the line but is otherwise
inconsistent with the style of values printed elsewhere, ie. without the
"=" between name and value.
But it seems it's been quite inconsistent everywhere. The only place
where the style is unified is tracepoints. I'm not sure if we should do
the same in the normal syslog messges, either with the space as
delimiter or with "=". In both cases the "," can be dropped though.
prev parent reply other threads:[~2025-06-05 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 15:24 [PATCH] btrfs: add comma delimiter for zone_unusable to space_info dump Johannes Thumshirn
2025-06-05 20:43 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605204335.GT4037@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox