From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.cz>
Cc: Boris Burkov <boris@bur.io>, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/7] btrfs: accessors: use type sizeof constants directly
Date: Mon, 7 Jul 2025 16:25:23 +0200 [thread overview]
Message-ID: <20250707142523.GG4453@twin.jikos.cz> (raw)
In-Reply-To: <20250703212015.GZ31241@suse.cz>
On Thu, Jul 03, 2025 at 11:20:15PM +0200, David Sterba wrote:
> > nit: the names oil and part are pretty non-sensical to me. Oil used to
> > be oip for Offset In Page. Is it Offset In foLio?
> >
> > I can't figure out what part should mean.
>
> It confused me the whole time I was looking at the code, it snuck in
> with the folio changes, it should have been 'oif' follwing the previous
> naming pattern.
>
> > So while I see why you're doing all the changes, I can' help but notice
> > that you removed the two named variables with logical names and left the
> > confusing ones. :)
>
> So I can sneak in a patch renaming it at the beginning or at the end,
> naming it 'oif' or 'foff' (there's the eb related offset as parameter so
> we need some kind of distinction).
Appended a patch renaming it to 'oif'.
next prev parent reply other threads:[~2025-07-07 14:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 17:23 [PATCH 0/7] Set/get accessor speedups David Sterba
2025-07-01 17:23 ` [PATCH 1/7] btrfs: accessors: simplify folio bounds checks David Sterba
2025-07-01 17:23 ` [PATCH 2/7] btrfs: accessors: use type sizeof constants directly David Sterba
2025-07-02 17:58 ` Boris Burkov
2025-07-03 21:20 ` David Sterba
2025-07-07 14:25 ` David Sterba [this message]
2025-07-01 17:23 ` [PATCH 3/7] btrfs: accessors: inline eb bounds check and factor out the error report David Sterba
2025-07-02 18:00 ` Boris Burkov
2025-07-03 21:16 ` David Sterba
2025-07-01 17:23 ` [PATCH 4/7] btrfs: accessors: compile-time fast path for u8 David Sterba
2025-07-01 17:23 ` [PATCH 5/7] btrfs: accessors: compile-time fast path for u16 David Sterba
2025-07-01 17:23 ` [PATCH 6/7] btrfs: accessors: set target address at initialization David Sterba
2025-07-01 17:23 ` [PATCH 7/7] btrfs: accessors: factor out split memcpy with two sources David Sterba
2025-07-02 18:53 ` Boris Burkov
2025-07-03 20:57 ` David Sterba
2025-07-02 18:54 ` [PATCH 0/7] Set/get accessor speedups Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707142523.GG4453@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox