Re: [PATCH 0/2] btrfs: be less verbose on automatic bg reclaim

[Boris Burkov <boris@bur.io>]

On Tue, Jul 08, 2025 at 08:55:01AM +0200, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> BTRFS filesystems with active automatic block-group reclaim (this
> especially hits zoned file systems where automatic block-group reclaim is
> used for garbage collection) do a lot of log spamming, because every
> relocated block group is accompanied by three prints at info level.
> 
> The first patch removes the info message that is only present with
> automatic block group reclaim, we have a tracepoint right next to it so
> there's no need for the message at all.
> 
> The second patch introduces a `verbose` parameter for
> `btrfs_relocate_chunk()` and `btrfs_relocate_block_group()` to control if
> we want to add printks or not. Automatic reclaim calls into
> `btrfs_relocate_chunk()` setting `verbose` to false while the user-space
> triggered balance code path sets `verbose` to true retaining the old
> behaviour. 

We also struggle with the spam at Meta with automatic reclaim enabled
though quite a bit less with dynamic.. :) In particular, users often
think it means there is some kind of btrfs error happening.

This looks like a good compromise to me, and I'd be quite happy to see
it go in.

Reviewed-by: Boris Burkov <boris@bur.io>

Thanks!

> 
> Johannes Thumshirn (2):
>   btrfs: remove redundant auto reclaim log message
>   btrfs: don't print relocation messages from auto reclaim
> 
>  fs/btrfs/block-group.c |  8 +-------
>  fs/btrfs/relocation.c  | 12 ++++++++----
>  fs/btrfs/relocation.h  |  3 ++-
>  fs/btrfs/volumes.c     | 14 ++++++++------
>  fs/btrfs/volumes.h     |  3 ++-
>  5 files changed, 21 insertions(+), 19 deletions(-)
> 
> -- 
> 2.50.0
>