Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Zoltan Racz <racz.zoli@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Zoltan Racz <racz.zoli@gmail.com>
Subject: [PATCH] btrfs-progs: Fix get_partition_sector_size_sysfs() to handle loopback and device mapper devices
Date: Fri,  1 Aug 2025 14:03:18 +0300	[thread overview]
Message-ID: <20250801110318.37249-1-racz.zoli@gmail.com> (raw)

Commit e39ed66 added get_partition_sector_size_sysfs() used by "btrfs device usage"
which returns the sector size of a partition (or its parent). After more testing 
it turned out it couldn`t handle loopback or mapper devices. This patch adds a fix
for them.

Signed-off-by: Zoltan Racz <racz.zoli@gmail.com>
---
 common/device-utils.c | 48 +++++++++++++++++++++++++++++--------------
 1 file changed, 33 insertions(+), 15 deletions(-)

diff --git a/common/device-utils.c b/common/device-utils.c
index dd781bc5..a75194bf 100644
--- a/common/device-utils.c
+++ b/common/device-utils.c
@@ -353,26 +353,44 @@ static ssize_t get_partition_sector_size_sysfs(const char *name)
 	char sysfs[PATH_MAX] = {};
 	char sizebuf[128];
 
-	snprintf(link_path, PATH_MAX, "/sys/class/block/%s/..", name);
+	/*
+	 * First we look for hw_sector_size directly directly under 
+	 * /sys/class/block/[partition_name]/queue. In case of loopback and
+	 * device mapper devices there is no parent device (like /dev/sda1 -> /dev/sda), 
+	 * and the partition`s sysfs folder itself contains informations regarding 
+	 * the sector size
+	 */
+	snprintf(sysfs, PATH_MAX, "/sys/class/block/%s/queue/hw_sector_size", name);
+	sysfd = open(sysfs, O_RDONLY);
 
-	if (!realpath(link_path, real_path)) {
-		error("Failed to resolve realpath of %s: %s\n", link_path, strerror(errno));
-		return -1;
-	}
+	if (sysfd < 0) {
+		/*
+		 * If we couldn`t find it, it means our partition is created on a real 
+		 * device and we need to find its parent
+		 */
+		snprintf(link_path, PATH_MAX, "/sys/class/block/%s/..", name);
 
-	dev_name = basename(real_path);
+		if (!realpath(link_path, real_path)) {
+			error("Failed to resolve realpath of %s: %s\n", link_path, strerror(errno));
+			return -1;
+		}
 
-	if (!dev_name) {
-		error("Failed to determine basename for path %s\n", real_path);
-		return -1;
-	}
+		dev_name = basename(real_path);
 
-	snprintf(sysfs, PATH_MAX, "/sys/class/block/%s/queue/hw_sector_size", dev_name);
+		if (!dev_name) {
+			error("Failed to determine basename for path %s\n", real_path);
+			return -1;
+		}
 
-	sysfd = open(sysfs, O_RDONLY);
-	if (sysfd < 0) {
-		error("Error opening %s to determine dev sector size: %s\n", real_path, strerror(errno));
-		return -1;
+		memset(sysfs, 0, PATH_MAX);
+		snprintf(sysfs, PATH_MAX, "/sys/class/block/%s/queue/hw_sector_size", dev_name);
+
+		sysfd = open(sysfs, O_RDONLY);
+
+		if (sysfd < 0) {
+			error("Error opening %s to determine dev sector size: %s\n", real_path, strerror(errno));
+			return -1;
+		}
 	}
 
 	ret = sysfs_read_file(sysfd, sizebuf, sizeof(sizebuf));
-- 
2.48.1


             reply	other threads:[~2025-08-01 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 11:03 Zoltan Racz [this message]
2025-08-02  4:19 ` [PATCH] btrfs-progs: Fix get_partition_sector_size_sysfs() to handle loopback and device mapper devices Qu Wenruo
2025-08-02  9:29   ` Racz Zoli
2025-08-02  9:32     ` Qu Wenruo
2025-08-02 12:45       ` Racz Zoli
2025-08-02 23:16         ` Qu Wenruo
2025-08-06  3:59 ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250801110318.37249-1-racz.zoli@gmail.com \
    --to=racz.zoli@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox