From: Boris Burkov <boris@bur.io>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] btrfs-progs: updates related to seed device and v6.17 kernel
Date: Tue, 5 Aug 2025 11:38:20 -0700 [thread overview]
Message-ID: <20250805183820.GC4088788@zen.localdomain> (raw)
In-Reply-To: <cover.1754265134.git.wqu@suse.com>
On Mon, Aug 04, 2025 at 09:22:35AM +0930, Qu Wenruo wrote:
> Kernel commit 40426dd147ff ("btrfs: use the super_block as holder when
> mounting file systems") changed the block device holder so that each
> device of a mounted btrfs can only belong to a single fs.
>
> This is fine for most users, but for a corner case of seed devices, it
> can be problematic.
>
> As previously we allow the same seed device to be mounted through both
> the seed device and the sprouted fs, as at that time all btrfs devices
> share the same holder.
>
> But now since each block device can only belong to a single mounted fs,
> it means the seed device can only be mounted through either the seed
> device itself or a sprouted fs, not both at the same time.
>
> This series will update the docs to be more explicit about the seed
> device mounting behavior, and updated the test case misc/046 to follow
> the new kernel behavior.
>
> And since we're here, also update a note where newer kernel fix a bug in
> orphan roots cleanup.
Looks good to me, thanks.
Reviewed-by: Boris Burkov <boris@bur.io>
>
>
> Qu Wenruo (3):
> btrfs-progs: docs/seed: update a note related to orphan roots cleanup
> btrfs-progs: docs/seed: add extra notes for v6.17 and newer kernels
> btrfs-progs: misc-tests: do not try to mount a block device into
> different filesystems
>
> Documentation/ch-seeding-device.rst | 14 +++++++++++++-
> tests/misc-tests/046-seed-multi-mount/test.sh | 17 ++++++++---------
> 2 files changed, 21 insertions(+), 10 deletions(-)
>
> --
> 2.50.1
>
prev parent reply other threads:[~2025-08-05 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-03 23:52 [PATCH 0/3] btrfs-progs: updates related to seed device and v6.17 kernel Qu Wenruo
2025-08-03 23:52 ` [PATCH 1/3] btrfs-progs: docs/seed: update a note related to orphan roots cleanup Qu Wenruo
2025-08-03 23:52 ` [PATCH 2/3] btrfs-progs: docs/seed: add extra notes for v6.17 and newer kernels Qu Wenruo
2025-08-03 23:52 ` [PATCH 3/3] btrfs-progs: misc-tests: do not try to mount a block device into different filesystems Qu Wenruo
2025-08-05 18:38 ` Boris Burkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250805183820.GC4088788@zen.localdomain \
--to=boris@bur.io \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox