Re: [PATCH] btrfs: restore mount option info messages during mount

[David Sterba <dsterba@suse.cz>]

On Mon, Aug 11, 2025 at 05:08:39PM +0900, Kyoji Ogasawara wrote:
> > > @@ -1428,7 +1430,6 @@ static void btrfs_emit_options(struct btrfs_fs_info *info,
> > >  {
> > >       btrfs_info_if_set(info, old, NODATASUM, "setting nodatasum");
> > >       btrfs_info_if_set(info, old, DEGRADED, "allowing degraded mounts");
> > > -     btrfs_info_if_set(info, old, NODATASUM, "setting nodatasum");
> >
> > Shouldn't this rather be NODATACOW? The logic around the option is the
> > same as for NODATASUM, but for some reason NODATACOW is under
> > btrfs_info_if_unset() call.
> >
> > >       btrfs_info_if_set(info, old, SSD, "enabling ssd optimizations");
> > >       btrfs_info_if_set(info, old, SSD_SPREAD, "using spread ssd allocation scheme");
> > >       btrfs_info_if_set(info, old, NOBARRIER, "turning off barriers");
> > > --
> > > 2.50.1
> > >
> 
> Thank you for your suggestion.
> I'll update the code to handle NODATASUM similarly to NODATACOW.
> 
> =====
> btrfs_info_if_set(info, old, NODATASUM, "setting nodatasum");
> btrfs_info_if_set(info, old, DEGRADED, "allowing degraded mounts");
> btrfs_info_if_set(info, old, NODATACOW, "setting nodatacow");
> ...
> btrfs_info_if_unset(info, old, NODATASUM, "setting datasum");
> btrfs_info_if_unset(info, old, NODATACOW, "setting datacow");
> =====
> 
> Let me know if there's anything else I should consider.

I haven't seen other problems in the mount options. Please send the
fixes as separate patches. Thanks.