Re: [PATCH 3/7] btrfs: add generic workspace manager initialization

[David Sterba <dsterba@suse.cz>]

On Thu, Aug 14, 2025 at 03:03:22PM +0930, Qu Wenruo wrote:
> This involves:
> 
> - Add generic_(alloc|free)_workspace_manager helpers.
>   These are the helper to alloc/free workspace_manager structure, which
>   will allocate a workspace_manager structure, initialize it, and
>   pre-allocate one workspace for it.
> 
> - Call generic_alloc_workspace_manager() inside
>   btrfs_alloc_compress_wsm()
>   For none, zlib and lzo compression algorithms.
> 
> - Call generic_alloc_workspace_manager() inside
>   btrfs_free_compress_wsm()
>   For none, zlib and lzo compression algorithms.
> 
> For now the generic per-fs workspace managers won't really have any effect,
> and all compression is still going through the global workspace manager.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  fs/btrfs/compression.c | 66 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
> index 0ee8a17abc30..8a7b2b802ddd 100644
> --- a/fs/btrfs/compression.c
> +++ b/fs/btrfs/compression.c
> @@ -773,6 +773,40 @@ static void free_workspace(int type, struct list_head *ws)
>  	}
>  }
>  
> +static int generic_alloc_workspace_manager(struct btrfs_fs_info *fs_info,
> +					   enum btrfs_compression_type type)

The helpers are static so you may drop the "generic_" prefix, we have
other unprefixed helpers like alloc_workspace etc.