From: Greg KH <gregkh@linuxfoundation.org>
To: Eliav Farber <farbere@amazon.com>
Cc: linux@armlinux.org.uk, jdike@addtoit.com, richard@nod.at,
anton.ivanov@cambridgegreys.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
tony.luck@intel.com, qiuxu.zhuo@intel.com, mchehab@kernel.org,
james.morse@arm.com, rric@kernel.org, harry.wentland@amd.com,
sunpeng.li@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch,
evan.quan@amd.com, james.qian.wang@arm.com, liviu.dudau@arm.com,
mihail.atanassov@arm.com, brian.starkey@arm.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robdclark@gmail.com, sean@poorly.run,
jdelvare@suse.com, linux@roeck-us.net, fery@cypress.com,
dmitry.torokhov@gmail.com, agk@redhat.com, snitzer@redhat.com,
dm-devel@redhat.com, rajur@chelsio.com, davem@davemloft.net,
kuba@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
malattia@linux.it, hdegoede@redhat.com, mgross@linux.intel.com,
intel-linux-scu@intel.com, artur.paszkiewicz@intel.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
sakari.ailus@linux.intel.com, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, jack@suse.com, tytso@mit.edu,
adilger.kernel@dilger.ca, dushistov@mail.ru,
luc.vanoostenryck@gmail.com, rostedt@goodmis.org,
pmladek@suse.com, sergey.senozhatsky@gmail.com,
andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
minchan@kernel.org, ngupta@vflare.org, akpm@linux-foundation.org,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
jmaloy@redhat.com, ying.xue@windriver.com, willy@infradead.org,
sashal@kernel.org, ruanjinjie@huawei.com,
David.Laight@aculab.com, herve.codina@bootlin.com,
Jason@zx2c4.com, bvanassche@acm.org, keescook@chromium.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-um@lists.infradead.org,
linux-edac@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, linux-hwmon@vger.kernel.org,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-staging@lists.linux.dev, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-sparse@vger.kernel.org,
linux-mm@kvack.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, tipc-discussion@lists.sourceforge.net,
stable@vger.kernel.org, jonnyc@amazon.com
Subject: Re: [PATCH 00/27 5.10.y] Backport minmax.h updates from v6.17-rc6
Date: Sun, 21 Sep 2025 19:28:44 +0200 [thread overview]
Message-ID: <2025092136-unelected-skirt-d91d@gregkh> (raw)
In-Reply-To: <20250919101727.16152-1-farbere@amazon.com>
On Fri, Sep 19, 2025 at 10:17:00AM +0000, Eliav Farber wrote:
> This series includes a total of 27 patches, to align minmax.h of
> v5.15.y with v6.17-rc6.
>
> The set consists of 24 commits that directly update minmax.h:
> 1) 92d23c6e9415 ("overflow, tracing: Define the is_signed_type() macro
> once")
But this isn't in 5.15.y, so how is this syncing things up?
I'm all for this, but I got confused here, at the first commit :)
> 2) 5efcecd9a3b1 ("minmax: sanity check constant bounds when clamping")
> 3) 2122e2a4efc2 ("minmax: clamp more efficiently by avoiding extra
> comparison")
> 4) f9bff0e31881 ("minmax: add in_range() macro")
> 5) c952c748c7a9 ("minmax: Introduce {min,max}_array()")
> 6) 5e57418a2031 ("minmax: deduplicate __unconst_integer_typeof()")
> 7) f6e9d38f8eb0 ("minmax: fix header inclusions")
> 8) d03eba99f5bf ("minmax: allow min()/max()/clamp() if the arguments
> have the same signedness.")
> 9) f4b84b2ff851 ("minmax: fix indentation of __cmp_once() and
> __clamp_once()")
> 10) 4ead534fba42 ("minmax: allow comparisons of 'int' against 'unsigned
> char/short'")
> 11) 867046cc7027 ("minmax: relax check to allow comparison between
> unsigned arguments and signed constants")
> 12) 3a7e02c040b1 ("minmax: avoid overly complicated constant
> expressions in VM code")
> 14) 017fa3e89187 ("minmax: simplify and clarify min_t()/max_t()
> implementation")
> 15) 1a251f52cfdc ("minmax: make generic MIN() and MAX() macros
> available everywhere")
> 18) dc1c8034e31b ("minmax: simplify min()/max()/clamp()
> implementation")
> 19) 22f546873149 ("minmax: improve macro expansion and type
> checking")
> 20) 21b136cc63d2 ("minmax: fix up min3() and max3() too")
> 21) 71ee9b16251e ("minmax.h: add whitespace around operators and after
> commas")
> 22) 10666e992048 ("minmax.h: update some comments")
> 23) b280bb27a9f7 ("minmax.h: reduce the #define expansion of min(),
> max() and clamp()")
> 24) a5743f32baec ("minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi
> test in clamp()")
> 25) c3939872ee4a ("minmax.h: move all the clamp() definitions after the
> min/max() ones")
> 26) 495bba17cdf9 ("minmax.h: simplify the variants of clamp()")
> 27) 2b97aaf74ed5 ("minmax.h: remove some #defines that are only
> expanded once")
Some of these are also only in newer kernels, which, as you know, is
generally a bad thing (i.e. I can't take patches only for older
kernels.)
I want these changes, as they are great, but can you perhaps provide
patch series for newer kernels first so that I can then take these?
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-21 17:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 10:17 [PATCH 00/27 5.10.y] Backport minmax.h updates from v6.17-rc6 Eliav Farber
2025-09-19 10:17 ` [PATCH 01/27 5.10.y] overflow, tracing: Define the is_signed_type() macro once Eliav Farber
2025-09-19 10:17 ` [PATCH 02/27 5.10.y] minmax: sanity check constant bounds when clamping Eliav Farber
2025-09-19 10:17 ` [PATCH 03/27 5.10.y] minmax: clamp more efficiently by avoiding extra comparison Eliav Farber
2025-09-19 10:17 ` [PATCH 04/27 5.10.y] minmax: add in_range() macro Eliav Farber
2025-09-22 13:10 ` Liviu Dudau
2025-09-19 10:17 ` [PATCH 05/27 5.10.y] minmax: Introduce {min,max}_array() Eliav Farber
2025-09-19 10:17 ` [PATCH 06/27 5.10.y] minmax: deduplicate __unconst_integer_typeof() Eliav Farber
2025-09-19 10:17 ` [PATCH 07/27 5.10.y] minmax: fix header inclusions Eliav Farber
2025-09-19 10:17 ` [PATCH 08/27 5.10.y] minmax: allow min()/max()/clamp() if the arguments have the same signedness Eliav Farber
2025-09-19 10:17 ` [PATCH 09/27 5.10.y] minmax: fix indentation of __cmp_once() and __clamp_once() Eliav Farber
2025-09-19 10:17 ` [PATCH 10/27 5.10.y] minmax: allow comparisons of 'int' against 'unsigned char/short' Eliav Farber
2025-09-19 10:17 ` [PATCH 11/27 5.10.y] minmax: relax check to allow comparison between unsigned arguments and signed constants Eliav Farber
2025-09-19 10:17 ` [PATCH 12/27 5.10.y] minmax: avoid overly complicated constant expressions in VM code Eliav Farber
2025-09-19 10:17 ` [PATCH 13/27 5.10.y] minmax: add a few more MIN_T/MAX_T users Eliav Farber
2025-09-19 10:17 ` [PATCH 14/27 5.10.y] minmax: simplify and clarify min_t()/max_t() implementation Eliav Farber
2025-09-19 10:17 ` [PATCH 15/27 5.10.y] minmax: make generic MIN() and MAX() macros available everywhere Eliav Farber
2025-09-19 10:17 ` [PATCH 16/27 5.10.y] lib: zstd: drop local MIN/MAX macros in favor of generic ones Eliav Farber
2025-09-19 10:17 ` [PATCH 17/27 5.10.y] minmax: don't use max() in situations that want a C constant expression Eliav Farber
2025-09-19 10:17 ` [PATCH 18/27 5.10.y] minmax: simplify min()/max()/clamp() implementation Eliav Farber
2025-09-19 10:17 ` [PATCH 19/27 5.10.y] minmax: improve macro expansion and type checking Eliav Farber
2025-09-19 10:17 ` [PATCH 20/27 5.10.y] minmax: fix up min3() and max3() too Eliav Farber
2025-09-19 10:17 ` [PATCH 21/27 5.10.y] minmax.h: add whitespace around operators and after commas Eliav Farber
2025-09-19 10:17 ` [PATCH 22/27 5.10.y] minmax.h: update some comments Eliav Farber
2025-09-19 10:17 ` [PATCH 23/27 5.10.y] minmax.h: reduce the #define expansion of min(), max() and clamp() Eliav Farber
2025-09-19 10:17 ` [PATCH 24/27 5.10.y] minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp() Eliav Farber
2025-09-19 10:17 ` [PATCH 25/27 5.10.y] minmax.h: move all the clamp() definitions after the min/max() ones Eliav Farber
2025-09-19 10:17 ` [PATCH 26/27 5.10.y] minmax.h: simplify the variants of clamp() Eliav Farber
2025-09-19 10:17 ` [PATCH 27/27 5.10.y] minmax.h: remove some #defines that are only expanded once Eliav Farber
2025-09-19 12:11 ` [PATCH 00/27 5.10.y] Backport minmax.h updates from v6.17-rc6 Christian König
2025-09-20 10:21 ` David Laight
2025-09-22 8:45 ` Christian König
2025-09-21 17:28 ` Greg KH [this message]
2025-09-21 21:37 ` Farber, Eliav
2025-09-22 5:02 ` Greg KH
2025-09-22 10:45 ` Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025092136-unelected-skirt-d91d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=David.Laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=adilger.kernel@dilger.ca \
--cc=agk@redhat.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=alexandre.torgue@st.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=artur.paszkiewicz@intel.com \
--cc=bp@alien8.de \
--cc=brian.starkey@arm.com \
--cc=bvanassche@acm.org \
--cc=christian.koenig@amd.com \
--cc=clm@fb.com \
--cc=coreteam@netfilter.org \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=dushistov@mail.ru \
--cc=evan.quan@amd.com \
--cc=farbere@amazon.com \
--cc=fery@cypress.com \
--cc=freedreno@lists.freedesktop.org \
--cc=fw@strlen.de \
--cc=harry.wentland@amd.com \
--cc=hdegoede@redhat.com \
--cc=herve.codina@bootlin.com \
--cc=hpa@zytor.com \
--cc=intel-linux-scu@intel.com \
--cc=jack@suse.com \
--cc=james.morse@arm.com \
--cc=james.qian.wang@arm.com \
--cc=jdelvare@suse.com \
--cc=jdike@addtoit.com \
--cc=jejb@linux.ibm.com \
--cc=jmaloy@redhat.com \
--cc=joabreu@synopsys.com \
--cc=jonnyc@amazon.com \
--cc=josef@toxicpanda.com \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=liviu.dudau@arm.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=luto@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=malattia@linux.it \
--cc=martin.petersen@oracle.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mgross@linux.intel.com \
--cc=mihail.atanassov@arm.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=pablo@netfilter.org \
--cc=peppe.cavallaro@st.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=qiuxu.zhuo@intel.com \
--cc=rajur@chelsio.com \
--cc=richard@nod.at \
--cc=robdclark@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rric@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sashal@kernel.org \
--cc=sean@poorly.run \
--cc=sergey.senozhatsky@gmail.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=tglx@linutronix.de \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tony.luck@intel.com \
--cc=tytso@mit.edu \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=ying.xue@windriver.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).