Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] btrfs: Avoid -Wflex-array-member-not-at-end warning
Date: Fri, 3 Oct 2025 17:15:09 +0200	[thread overview]
Message-ID: <20251003151509.GK4052@suse.cz> (raw)
In-Reply-To: <b59ed01f-d9d5-4de8-8a12-1e506962b2d9@embeddedor.com>

On Fri, Oct 03, 2025 at 03:51:24PM +0100, Gustavo A. R. Silva wrote:
> >>
> >> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> >> index 9230e5066fc6..2b7cf49a35bb 100644
> >> --- a/fs/btrfs/send.c
> >> +++ b/fs/btrfs/send.c
> >> @@ -178,7 +178,6 @@ struct send_ctx {
> >>   	u64 cur_inode_rdev;
> >>   	u64 cur_inode_last_extent;
> >>   	u64 cur_inode_next_write_offset;
> >> -	struct fs_path cur_inode_path;
> >>   	bool cur_inode_new;
> >>   	bool cur_inode_new_gen;
> >>   	bool cur_inode_deleted;
> >> @@ -305,6 +304,9 @@ struct send_ctx {
> >>   
> >>   	struct btrfs_lru_cache dir_created_cache;
> >>   	struct btrfs_lru_cache dir_utimes_cache;
> >> +
> >> +	/* Must be last --ends in a flexible-array member. */
> >                          ^^
> > 
> > Is this an en dash?
> 
> Not sure what you mean.

En dash is a punctuation mark not typically used in comments, nowadays
found in AI generated code/text. I was just curious.

  reply	other threads:[~2025-10-03 15:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-03 14:11 [PATCH][next] btrfs: Avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2025-10-03 14:35 ` David Sterba
2025-10-03 14:51   ` Gustavo A. R. Silva
2025-10-03 15:15     ` David Sterba [this message]
2025-10-03 15:21       ` Gustavo A. R. Silva
2025-10-06 16:06         ` David Sterba
2025-10-06 17:23 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251003151509.GK4052@suse.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=gustavo@embeddedor.com \
    --cc=gustavoars@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox