From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>, Christoph Hellwig <hch@lst.de>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org,
Hans Holmberg <hans.holmberg@wdc.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
Carlos Maiolino <cem@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH v3 3/3] generic: basic smoke for filesystems on zoned block devices
Date: Tue, 14 Oct 2025 06:33:12 +0200 [thread overview]
Message-ID: <20251014043312.GB30741@lst.de> (raw)
In-Reply-To: <20251013080759.295348-4-johannes.thumshirn@wdc.com>
On Mon, Oct 13, 2025 at 10:07:59AM +0200, Johannes Thumshirn wrote:
> +_cleanup()
> +{
> + if test -b /dev/zloop$ID; then
> + echo "remove id=$ID" > /dev/zloop-control
> + fi
> +}
> +mkdir -p "$zloopdir/$ID"
> +mkdir -p $mnt
> +_create_zloop $ID $zloopdir 256 2
> +zloop="/dev/zloop$ID"
To got back to my comments on the first round (sorry, slow to catch up
due to conference travel)+, I would expect most of this to be
in common/zloop helpers, i.e. have a helper that has basically all
the code in the cleanup helper except that it gets passed the ID, and
also have the +mkdir -p "$zloopdir/$ID" indluded in _create_zloop.
And maybe _create_zloop should also return the device name, turning
the above into
zloop=`_create_next_zloop $zloopdir 256 2`
?
prev parent reply other threads:[~2025-10-14 4:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 8:07 [PATCH v3 0/3] fstests: basic smoke test on zoned loop device Johannes Thumshirn
2025-10-13 8:07 ` [PATCH v3 1/3] common/zoned: add _require_zloop Johannes Thumshirn
2025-10-13 8:43 ` Naohiro Aota
2025-10-14 4:33 ` Christoph Hellwig
2025-10-13 8:07 ` [PATCH v3 2/3] common/zoned: add _create_zloop Johannes Thumshirn
2025-10-14 9:04 ` Naohiro Aota
2025-10-13 8:07 ` [PATCH v3 3/3] generic: basic smoke for filesystems on zoned block devices Johannes Thumshirn
2025-10-13 13:55 ` Anand Jain
2025-10-13 14:06 ` Johannes Thumshirn
2025-10-13 14:42 ` Anand Jain
2025-10-14 4:30 ` hch
2025-10-14 14:38 ` Anand Jain
2025-10-15 4:09 ` hch
2025-10-14 4:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014043312.GB30741@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox