From: "Darrick J. Wong" <djwong@kernel.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>, Christoph Hellwig <hch@lst.de>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org,
Hans Holmberg <hans.holmberg@wdc.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
Carlos Maiolino <cem@kernel.org>,
Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH v4 1/3] common/zoned: add _require_zloop
Date: Tue, 14 Oct 2025 13:53:53 -0700 [thread overview]
Message-ID: <20251014205353.GA6188@frogsfrogsfrogs> (raw)
In-Reply-To: <20251014084625.422974-2-johannes.thumshirn@wdc.com>
On Tue, Oct 14, 2025 at 10:46:23AM +0200, Johannes Thumshirn wrote:
> Add _require_zloop() function used by tests that require support for the
> zoned loopback block device.
>
> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Looks good to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> common/zoned | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/common/zoned b/common/zoned
> index eed0082a..41697b08 100644
> --- a/common/zoned
> +++ b/common/zoned
> @@ -37,3 +37,11 @@ _zone_capacity() {
> grep -Po "cap 0x[[:xdigit:]]+" | cut -d ' ' -f 2)
> echo $((size << 9))
> }
> +
> +_require_zloop()
> +{
> + modprobe zloop >/dev/null 2>&1
> + if [ ! -c "/dev/zloop-control" ]; then
> + _notrun "This test requires zoned loopback device support"
> + fi
> +}
> --
> 2.51.0
>
>
next prev parent reply other threads:[~2025-10-14 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 8:46 [PATCH v4 0/3] fstests: basic smoke test on zoned loop device Johannes Thumshirn
2025-10-14 8:46 ` [PATCH v4 1/3] common/zoned: add _require_zloop Johannes Thumshirn
2025-10-14 20:53 ` Darrick J. Wong [this message]
2025-10-14 8:46 ` [PATCH v4 2/3] common/zoned: add _create_zloop Johannes Thumshirn
2025-10-14 20:59 ` Darrick J. Wong
2025-10-15 8:45 ` Johannes Thumshirn
2025-10-14 8:46 ` [PATCH v4 3/3] generic: basic smoke for filesystems on zoned block devices Johannes Thumshirn
2025-10-14 21:02 ` Darrick J. Wong
2025-10-15 4:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014205353.GA6188@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox