From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Zorro Lang <zlang@redhat.com>, Christoph Hellwig <hch@lst.de>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org,
Hans Holmberg <hans.holmberg@wdc.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
Carlos Maiolino <cem@kernel.org>,
Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH v4 3/3] generic: basic smoke for filesystems on zoned block devices
Date: Wed, 15 Oct 2025 06:10:13 +0200 [thread overview]
Message-ID: <20251015041013.GC6880@lst.de> (raw)
In-Reply-To: <20251014210253.GC6188@frogsfrogsfrogs>
On Tue, Oct 14, 2025 at 02:02:53PM -0700, Darrick J. Wong wrote:
> > +_cleanup()
> > +{
> > + if test -b "$zloop"; then
> > + ID=$(echo $zloop | grep -oE '[0-9]+$')
> > + echo "remove id=$ID" > /dev/zloop-control
>
> Probably ought to be a teardown helper ^^
>
> _destroy_zloop() {
> local zloop="$1"
>
> test -b "$zloop" || return
> local id=$(echo $zloop | grep -oE '[0-9]+$')
>
> echo "remove id=$id" > /dev/zloop-control
> }
>
> Then everyone's cleanups can become:
Yes, that's actually something I asked for in the review for the last
version.
prev parent reply other threads:[~2025-10-15 4:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 8:46 [PATCH v4 0/3] fstests: basic smoke test on zoned loop device Johannes Thumshirn
2025-10-14 8:46 ` [PATCH v4 1/3] common/zoned: add _require_zloop Johannes Thumshirn
2025-10-14 20:53 ` Darrick J. Wong
2025-10-14 8:46 ` [PATCH v4 2/3] common/zoned: add _create_zloop Johannes Thumshirn
2025-10-14 20:59 ` Darrick J. Wong
2025-10-15 8:45 ` Johannes Thumshirn
2025-10-14 8:46 ` [PATCH v4 3/3] generic: basic smoke for filesystems on zoned block devices Johannes Thumshirn
2025-10-14 21:02 ` Darrick J. Wong
2025-10-15 4:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015041013.GC6880@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox