From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C065D312811 for ; Fri, 17 Oct 2025 10:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760697582; cv=none; b=nGwB1/O02JjS07dMKdmiiiTKyNaJWY/5fM7noenAWse0mt9szLl47mW0OgJdvapaDvf07OVYCjXH26yuuFR7d8F9nbWYbqv3mBkgmpk8u2sfN74IzlbuAWT7jWBiG7buPotmBZfauZlzyEbTa1nahv6dyP/jQYGmd5XRiSbx9dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760697582; c=relaxed/simple; bh=3icRH0liAsP7sjwZ2zPe1LVJ+1rHNTn97LK8vpGCQW4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Adu/uPUUoxCDkxpYwtz1IUa3+poYp3CZ1rkU985FksxixQM4iTYy7Njnb6vvpDfE5siwxiFeZrYWWkXxEH6DH+v9uxtemq+o2HrwtYu1QQlwJnunRkkPlpjuYKShuXNSgt19NndUKYgL5jWxnI+4jBStuo5Rp2mS4ENmAS0537A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PIsJBmJr; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PIsJBmJr" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4711f156326so4096545e9.1 for ; Fri, 17 Oct 2025 03:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760697579; x=1761302379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J7jEt2bBtS4lkQKEiP8Z3A8t05k/u/Bf60nmYvlGeNY=; b=PIsJBmJrMIRiaJc377tUJB/Q7jAPNt+/GfB5DIWte0H+rpzZbktzK6V+z8PoTBEV3n PXbatbbxsvCpMeXkPh4Pkvh9x+HOK6mzX+0OzVatQKjGwmZNV11fZy0DnubGUWu7nJ6n jasj0SZuwGnlUMILN0xZgaeY076K9PTQujkfuVbgDDdSQScYdhhewD9JZRaz7iP2vrle zdS/rqCAViynmb7CQ9RZonSn5DVK1QXDKU5pNP36zNP9FclbCe3nm03cJVXUqgw3fUq8 SlR5IsNq8+6DmDNdOTasECZ6L6JHpgAA6tHuKzz0GiHqzUiWMXyEmbkzyepPkpPIooHQ mHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760697579; x=1761302379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J7jEt2bBtS4lkQKEiP8Z3A8t05k/u/Bf60nmYvlGeNY=; b=F9wtAPh5uAnZuc7I2m6Pi8xWfiZ1/9Lnb+ztuXf8QiDfOOgg6WcU9nLGi+T152/h4v xTQ15mobglDltUtmCmK6pDxeQ5p3cd8kX/YjQ7iUme8z7jzfHA7Qond/btq+qTohw/BO ZEk+mbA1Uw3xfAiup4Hq9PRQLJZybErJrjbpmQk0RaHSjXBQ2fSMAUMOrzcsgNOihOKk cl2E/UGTV0SCXXFCQaK4AFJtSzZGxPqMm/yD6eOdc2DZfUWoRrO6N7v1pTr7f6+M/2n7 mb/BVgmeUfNAlG7+HRsFrha9n4A6Ig1l7TVGsuP3RHx2GMvaJcpZJMysSEY6oFl4X0ug Otyw== X-Gm-Message-State: AOJu0Yz7ifC1B3hycVJDX9byQOGG2OPhETP88elBOE10j/C7fP5iDiVS e6Agz9FxETngds7sQr4R+VJVV9iTKb+RBzQBlvxUgSh8DbXdn1+saJHj X-Gm-Gg: ASbGncvqGG8TitlZOqdWbKi3hZ9+fP4WqFAC2uCr67YoMpp6qQ+x/HO9GFtlmarEuG3 pywO9JlQgqygdiRmUnW7etikOhnSw407Z7EpShcgREUlqwIJ1GSdWnxisPD3OuHomV6lifoFGNm uHe6K/Ikn3+7RqlNO3BS4re4AA2vaWeDTTznP4Mu1xWS8BrT5cKAWu1HAGzX0mzOs4VbzYMuQl/ 95PN7lBe9QpWz6U5GkgZa6fB5HudQwV2dFT+wTowUA8+B+wKXJzkporCIOjXTR9J6HC6PdPmEGn KxqNGc4hLFdQaUgo7PhiZVYiZtID0G5DD38TrOuCXgEKB6hvS/9sTrXivZpG+7McXaF6WOAbt1l v+lqDV2GQ5L6nWLgGDIxQBdp4O2Aj6gV3QykSeqYU9qVnNVucAErEEUMNPNANCkm24yGzBCi/O+ 5tlwvYvqi3+ih5nj/sAbhDsw== X-Google-Smtp-Source: AGHT+IEHuo1AdfTtiQhHrCKaYLVYpg367t+Hy0cy8LVgBCFvR9kcQy/2El+YmymF463hMk6d8OPEzg== X-Received: by 2002:a05:6000:400a:b0:425:769e:515a with SMTP id ffacd0b85a97d-42704d9e8f7mr2460323f8f.42.1760697578950; Fri, 17 Oct 2025 03:39:38 -0700 (PDT) Received: from localhost ([212.73.77.104]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-426ce5e10e8sm40199791f8f.39.2025.10.17.03.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Oct 2025 03:39:38 -0700 (PDT) From: Askar Safin To: quwenruo.btrfs@gmx.com Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: Long running ioctl and pm, which should have higher priority? Date: Fri, 17 Oct 2025 13:39:32 +0300 Message-ID: <20251017103932.1176085-1-safinaskar@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <3a77483d-d8c3-4e1b-8189-70a2a741517e@gmx.com> References: <3a77483d-d8c3-4e1b-8189-70a2a741517e@gmx.com> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Qu Wenruo : > But there is a question concerning me, which should have the higher > priority? The long running ioctl or pm? Of course, pm. I have a huge btrfs fs on a laptop. I don't want scrub to prevent suspend, even if that suspend is happening automatically. > Furthermore the interruption may be indistinguishable between pm and > real user signals (SIGINT etc). If we interrupted because of signal, ioctl should return EINTR. This is what all other syscalls do. If we were cancelled, we should return ECANCELED. If we interrupted because of process freeze or fs freeze, then... I don't know what we should do in this case, but definitely not ECANCELED (because we are not cancelled). EINTR will go, or maybe something else (EAGAIN?). Then, userspace program "btrfs scrub" can resume process if it got EINTR. (But this is totally unimportant for me.) Also, please CC me when sending any emails about this scrub/trim bug. -- Askar Safin