From: David Sterba <dsterba@suse.cz>
To: Leo Martins <loemra.dev@gmail.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: fix delayed_node ref_tracker use after free
Date: Wed, 22 Oct 2025 08:42:40 +0200 [thread overview]
Message-ID: <20251022064240.GT13776@twin.jikos.cz> (raw)
In-Reply-To: <e5d6dd45f720f2543ca4ea7ee3e66454ef55f639.1761001854.git.loemra.dev@gmail.com>
On Mon, Oct 20, 2025 at 04:16:15PM -0700, Leo Martins wrote:
> Move the print before releasing the delayed node.
>
> In my initial testing there was a bug that was causing delayed_nodes
> to not get freed which is why I put the print after the release. This
> obviously neglects the case where the delayed node is properly freed.
>
> Add condition to make sure we only print if we have more than one
> reference to the delayed_node to prevent printing when we only have
> the reference taken in btrfs_kill_all_delayed_nodes().
>
> Fixes: b767a28d6154 ("btrfs: print leaked references in kill_all_delayed_nodes()")
> Signed-off-by: Leo Martins <loemra.dev@gmail.com>
Added to for-next, thanks.
prev parent reply other threads:[~2025-10-22 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 23:16 [PATCH] btrfs: fix delayed_node ref_tracker use after free Leo Martins
2025-10-21 5:26 ` Christoph Hellwig
2025-10-22 6:42 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022064240.GT13776@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=loemra.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox