From: Nathan Chancellor <nathan@kernel.org>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
linux-kbuild@vger.kernel.org,
jfs-discussion@lists.sourceforge.net
Subject: Re: [PATCH 1/2] Kbuild: enable -fms-extensions
Date: Thu, 23 Oct 2025 18:45:52 +0200 [thread overview]
Message-ID: <20251023164552.GC2090923@ax162> (raw)
In-Reply-To: <0b2bc5fb-2345-47dd-b980-120805d3c69f@oracle.com>
On Thu, Oct 23, 2025 at 09:17:47AM -0500, Dave Kleikamp wrote:
> On 10/23/25 7:40AM, Nathan Chancellor wrote:
> > Something like this is all it takes to resolve the issue, so I will send
> > a patch for formal review/acking but I wanted to bring it up ahead of
> > time in case this is unpalpable and we should throw these changes out of
> > -next instead of forward fixing.
>
> I'm on vacation now, so I may be slow to respond to a future patch, so I'll
> go ahead and give you my ack to this.
>
> Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Great, thanks for the tag and taking a look quickly!
> > diff --git a/fs/jfs/jfs_incore.h b/fs/jfs/jfs_incore.h
> > index 10934f9a11be..5aaafedb8fbc 100644
> > --- a/fs/jfs/jfs_incore.h
> > +++ b/fs/jfs/jfs_incore.h
> > @@ -76,14 +76,14 @@ struct jfs_inode_info {
> > struct {
> > unchar _unused[16]; /* 16: */
> > dxd_t _dxd; /* 16: */
> > - /* _inline may overflow into _inline_ea when needed */
> > + /* _inline_sym may overflow into _inline_ea when needed */
> > /* _inline_ea may overlay the last part of
> > * file._xtroot if maxentry = XTROOTINITSLOT
> > */
> > union {
> > struct {
> > /* 128: inline symlink */
> > - unchar _inline[128];
> > + unchar _inline_sym[128];
> > /* 128: inline extended attr */
> > unchar _inline_ea[128];
> > };
> > @@ -101,7 +101,7 @@ struct jfs_inode_info {
> > #define i_imap u.file._imap
> > #define i_dirtable u.dir._table
> > #define i_dtroot u.dir._dtroot
> > -#define i_inline u.link._inline
> > +#define i_inline u.link._inline_sym
> > #define i_inline_ea u.link._inline_ea
> > #define i_inline_all u.link._inline_all
>
next prev parent reply other threads:[~2025-10-23 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 14:22 [PATCH 0/2] Kbuild: enable -fms-extensions, make btrfs the first user Rasmus Villemoes
2025-10-20 14:22 ` [PATCH 1/2] Kbuild: enable -fms-extensions Rasmus Villemoes
2025-10-22 16:15 ` Nathan Chancellor
2025-10-22 20:35 ` Rasmus Villemoes
2025-10-22 21:11 ` Nathan Chancellor
2025-10-23 12:40 ` Nathan Chancellor
2025-10-23 14:17 ` Dave Kleikamp
2025-10-23 16:45 ` Nathan Chancellor [this message]
2025-10-20 14:22 ` [PATCH 2/2] btrfs: send: make use of -fms-extensions for defining struct fs_path Rasmus Villemoes
2025-10-20 19:48 ` Linus Torvalds
2025-10-22 5:24 ` David Sterba
2025-10-22 5:30 ` [PATCH 0/2] Kbuild: enable -fms-extensions, make btrfs the first user David Sterba
2025-10-22 16:17 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023164552.GC2090923@ax162 \
--to=nathan@kernel.org \
--cc=dave.kleikamp@oracle.com \
--cc=dsterba@suse.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox