From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C4229ACC5; Fri, 31 Oct 2025 06:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761891426; cv=none; b=L73PwGAvXAgm67bpb6EcS7JiyNJRLLLXrJlhYPWUdvJWFblMbSLA9DWNucX/Ydv6rrJ33FgF4fkB8KpaIYLoY4PdDnFEXL8HIziqRl1o4xQPPShlxxHG0sYUPi6G1vgQ5XuMMVtYQKk6ZNsWXaMdWVoPGlkVtmmdkOpgUT7C0X4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761891426; c=relaxed/simple; bh=jAeMnW5IAIhrVXXBBq3h2j8UAN/r4N1L4IH+uugW13E=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oNVYlLPkbBXdddecE0+e/tK/FKjjE9nGmeE0YEpaUJF4FAsnDkmgrIuLIhSxDiDr8mvGTsrZ7K1HeOpkdaH1/RzefjJSn6kLUuycFcTMVBxbV1EU6H59XkJDxLehjvs5h9kpfMbPHaMp3Ae1/1FoOZgF0r9NZiloVH17kS6KUVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gcaZ3PnV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gcaZ3PnV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74DA6C4CEE7; Fri, 31 Oct 2025 06:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761891424; bh=jAeMnW5IAIhrVXXBBq3h2j8UAN/r4N1L4IH+uugW13E=; h=From:To:Subject:Date:In-Reply-To:References:From; b=gcaZ3PnVYv9Qq4D6p+2NtpRx0NyB2RLfe6yf/s2qdOcZIRCJPcqZ97s8kODXpHinW k+Ay4G/E6RkM9iRPqgJMUZcD2AC/GHhBLNc7W0o0WaDKqRUDAzarkVOH8pDXOMps4U sB6tl7VIyIVo5ZO4AdQiey9+JiuAf9eLcxf7Pna9I96Oou+HThVAp7VXm1SYThACTM 9wgMJpj2e6BmYahF0l2Et1/f8xQC8YiaiCXsNnYPw+iPhCIBTbhb903jz38XgbBLlA mgopxynXMZ6enhlCugmD5wOs5Q3dRCw0ZeNfTdbsv3SKOdwnrd4y6x87UqkzUa6StL NLEw6PTuFNXxQ== From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Keith Busch , Christoph Hellwig , dm-devel@lists.linux.dev, Mike Snitzer , Mikulas Patocka , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, Carlos Maiolino , linux-btrfs@vger.kernel.org, David Sterba Subject: [PATCH 05/13] block: reorganize struct blk_zone_wplug Date: Fri, 31 Oct 2025 15:12:59 +0900 Message-ID: <20251031061307.185513-6-dlemoal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251031061307.185513-1-dlemoal@kernel.org> References: <20251031061307.185513-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reorganize the fields of struct blk_zone_wplug to remove a hole after the wp_offset field and avoid having the bio_work structure split between 2 cache lines. No functional changes. Signed-off-by: Damien Le Moal --- block/blk-zoned.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/block/blk-zoned.c b/block/blk-zoned.c index 603ed8dc472c..29891253a920 100644 --- a/block/blk-zoned.c +++ b/block/blk-zoned.c @@ -39,6 +39,11 @@ static const char *const zone_cond_name[] = { /* * Per-zone write plug. * @node: hlist_node structure for managing the plug using a hash table. + * @bio_list: The list of BIOs that are currently plugged. + * @bio_work: Work struct to handle issuing of plugged BIOs + * @rcu_head: RCU head to free zone write plugs with an RCU grace period. + * @disk: The gendisk the plug belongs to. + * @lock: Spinlock to atomically manipulate the plug. * @ref: Zone write plug reference counter. A zone write plug reference is * always at least 1 when the plug is hashed in the disk plug hash table. * The reference is incremented whenever a new BIO needing plugging is @@ -48,27 +53,22 @@ static const char *const zone_cond_name[] = { * reference is dropped whenever the zone of the zone write plug is reset, * finished and when the zone becomes full (last write BIO to the zone * completes). - * @lock: Spinlock to atomically manipulate the plug. * @flags: Flags indicating the plug state. * @zone_no: The number of the zone the plug is managing. * @wp_offset: The zone write pointer location relative to the start of the zone * as a number of 512B sectors. - * @bio_list: The list of BIOs that are currently plugged. - * @bio_work: Work struct to handle issuing of plugged BIOs - * @rcu_head: RCU head to free zone write plugs with an RCU grace period. - * @disk: The gendisk the plug belongs to. */ struct blk_zone_wplug { struct hlist_node node; - refcount_t ref; - spinlock_t lock; - unsigned int flags; - unsigned int zone_no; - unsigned int wp_offset; struct bio_list bio_list; struct work_struct bio_work; struct rcu_head rcu_head; struct gendisk *disk; + spinlock_t lock; + refcount_t ref; + unsigned int flags; + unsigned int zone_no; + unsigned int wp_offset; }; static inline unsigned int disk_zone_wplugs_hash_size(struct gendisk *disk) -- 2.51.0