Re: [PATCH v6 8/8] btrfs: set the appropriate free space settings in reconfigure

[David Sterba <dsterba@suse.cz>]

On Thu, Nov 13, 2025 at 12:24:33PM +0100, Daniel Vacek wrote:
> On Thu, 13 Nov 2025 at 11:32, David Sterba <dsterba@suse.cz> wrote:
> > On Wed, Nov 12, 2025 at 08:36:08PM +0100, Daniel Vacek wrote:
> > > From: Josef Bacik <josef@toxicpanda.com>
> > >
> > > btrfs/330 uncovered a problem where we were accidentally turning off the
> > > free space tree when we do the transition from ro->rw.  This happens
> > > because we don't update
> >
> > Missing text.
> 
> Hmm, this patch is new to v5. It doesn't even look encryption related.
> I have no idea what Josef really means here.
> 
> The whole idea seems to be to call
> btrfs_set_free_space_cache_settings() from btrfs_reconfigure() and to
> update the ctx->mount_opt instead of fs_info->mount_opt while
> remounting.
> 
> And btrfs/330 is not failing even with the full patchset applied
> without this patch. I'm wondering if it is still needed after those
> years?

Maybe it it's not, as all the patches are somehow independent you can
drop it for now. We can add it later if need be.