From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Daniel Vacek <neelx@suse.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/6] btrfs: move inode_to_path higher in backref.c
Date: Wed, 19 Nov 2025 13:49:31 +0100 [thread overview]
Message-ID: <20251119124931.GH13846@twin.jikos.cz> (raw)
In-Reply-To: <CAL3q7H5AVVyeNxdXPJyGM9ys7WLncTWnwAciuEtThbWpzZGe2Q@mail.gmail.com>
On Wed, Nov 19, 2025 at 12:21:52PM +0000, Filipe Manana wrote:
> On Tue, Nov 18, 2025 at 4:16 PM Daniel Vacek <neelx@suse.com> wrote:
> >
> > From: Josef Bacik <josef@toxicpanda.com>
> >
> > We have a prototype and then the definition lower below, we don't need
> > to do this, simply move the function to where the prototype is.
>
> According to our development notes here:
>
> https://btrfs.readthedocs.io/en/latest/dev/Development-notes.html
>
> Under the "Function declarations" section we have:
>
> "avoid prototypes for static functions, order them in new code in a
> way that does not need it
>
> but don’t move static functions just to get rid of the prototype"
>
> So what's the motivation for moving the function?
Right, I thought the other fscrypt patches needed that for some reason
but after checking again they don't, I'll drop the patch. Thanks.
next prev parent reply other threads:[~2025-11-19 12:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 16:08 [PATCH v8 0/6] btrfs: add fscrypt support, PART 1 Daniel Vacek
2025-11-18 16:08 ` [PATCH v7 1/6] btrfs: disable various operations on encrypted inodes Daniel Vacek
2025-11-18 16:08 ` [PATCH v7 2/6] btrfs: disable verity " Daniel Vacek
2025-11-18 16:08 ` [PATCH v7 3/6] btrfs: add orig_logical to btrfs_bio Daniel Vacek
2025-11-18 16:08 ` [PATCH v7 4/6] btrfs: don't rewrite ret from inode_permission Daniel Vacek
2025-11-19 10:07 ` Johannes Thumshirn
2025-11-19 10:13 ` Johannes Thumshirn
2025-11-19 12:08 ` David Sterba
2025-11-18 16:08 ` [PATCH v7 5/6] btrfs: move inode_to_path higher in backref.c Daniel Vacek
2025-11-19 10:10 ` Johannes Thumshirn
2025-11-19 12:21 ` Filipe Manana
2025-11-19 12:49 ` David Sterba [this message]
2025-11-18 16:08 ` [PATCH v7 6/6] btrfs: don't search back for dir inode item in INO_LOOKUP_USER Daniel Vacek
2025-11-19 10:16 ` Johannes Thumshirn
2025-11-19 8:23 ` [PATCH v8 0/6] btrfs: add fscrypt support, PART 1 Christoph Hellwig
2025-11-19 8:59 ` David Sterba
2025-11-19 9:06 ` Christoph Hellwig
2025-11-19 11:16 ` David Sterba
2025-11-19 12:16 ` David Sterba
2025-11-19 14:09 ` Daniel Vacek
-- strict thread matches above, loose matches on Subject: below --
2025-11-18 16:00 [PATCH v7 0/7] " Daniel Vacek
2025-11-18 16:00 ` [PATCH v7 5/6] btrfs: move inode_to_path higher in backref.c Daniel Vacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119124931.GH13846@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelx@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox