From: Sun YangKai <sunk67188@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Sun YangKai <sunk67188@gmail.com>, Boris Burkov <boris@bur.io>
Subject: [PATCH v4 2/2] btrfs: consolidate reclaim readiness checks in btrfs_should_reclaim()
Date: Wed, 14 Jan 2026 11:47:03 +0800 [thread overview]
Message-ID: <20260114035126.20095-3-sunk67188@gmail.com> (raw)
In-Reply-To: <20260114035126.20095-1-sunk67188@gmail.com>
Move the filesystem state validation from btrfs_reclaim_bgs_work() into
btrfs_should_reclaim() to centralize the reclaim eligibility logic.
Since it is the only caller of btrfs_should_reclaim(), there's no
functional change.
Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: Sun YangKai <sunk67188@gmail.com>
---
fs/btrfs/block-group.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
index 79d86b233dda..1594d58304b9 100644
--- a/fs/btrfs/block-group.c
+++ b/fs/btrfs/block-group.c
@@ -1804,6 +1804,12 @@ static int reclaim_bgs_cmp(void *unused, const struct list_head *a,
static inline bool btrfs_should_reclaim(const struct btrfs_fs_info *fs_info)
{
+ if (!test_bit(BTRFS_FS_OPEN, &fs_info->flags))
+ return false;
+
+ if (btrfs_fs_closing(fs_info))
+ return false;
+
if (btrfs_is_zoned(fs_info))
return btrfs_zoned_should_reclaim(fs_info);
return true;
@@ -1838,12 +1844,6 @@ void btrfs_reclaim_bgs_work(struct work_struct *work)
struct btrfs_space_info *space_info;
LIST_HEAD(retry_list);
- if (!test_bit(BTRFS_FS_OPEN, &fs_info->flags))
- return;
-
- if (btrfs_fs_closing(fs_info))
- return;
-
if (!btrfs_should_reclaim(fs_info))
return;
--
2.52.0
next prev parent reply other threads:[~2026-01-14 3:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 3:47 [PATCH v4 0/2] btrfs: fix periodic reclaim condition Sun YangKai
2026-01-14 3:47 ` [PATCH v4 1/2] " Sun YangKai
2026-02-08 18:24 ` Chris Mason
2026-02-09 13:08 ` Sun YangKai
2026-02-09 13:14 ` Sun YangKai
2026-01-14 3:47 ` Sun YangKai [this message]
2026-01-14 11:16 ` [PATCH v4 2/2] btrfs: consolidate reclaim readiness checks in btrfs_should_reclaim() Johannes Thumshirn
2026-01-21 1:36 ` [PATCH v4 0/2] btrfs: fix periodic reclaim condition Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114035126.20095-3-sunk67188@gmail.com \
--to=sunk67188@gmail.com \
--cc=boris@bur.io \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox